Open
Bug 1491490
Opened 6 years ago
Updated 1 year ago
Kill wantXrays
Categories
(Core :: XPConnect, enhancement, P3)
Core
XPConnect
Tracking
()
NEW
People
(Reporter: bholley, Unassigned)
References
(Depends on 1 open bug, Blocks 1 open bug)
Details
Reporter | ||
Comment 1•6 years ago
|
||
I wrote a 1-line patch to always set wantXrays to false, and see what breaks:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2aa151d3be75aacf25083f00d835c921ab6ff669
Comment 2•6 years ago
|
||
(In reply to Bobby Holley (:bholley) from comment #1)
> I wrote a 1-line patch to always set wantXrays to false, and see what breaks:
>
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=2aa151d3be75aacf25083f00d835c921ab6ff669
Not *too* orange :)
Priority: -- → P3
Comment 3•6 years ago
|
||
(In reply to Andrew Overholt [:overholt] from comment #2)
> (In reply to Bobby Holley (:bholley) from comment #1)
> > I wrote a 1-line patch to always set wantXrays to false, and see what breaks:
> >
> > https://treeherder.mozilla.org/#/
> > jobs?repo=try&revision=2aa151d3be75aacf25083f00d835c921ab6ff669
>
> Not *too* orange :)
Fortunately, most of that orange is just tests of Sandbox X-ray functionality. It looks like the devtools tests are doing something a bit weird. Not sure what.
Not quite sure about the Marionette harness one either. We may need to change that to create content sandboxes with an expanded principal.
Comment 4•6 years ago
|
||
Hi Bobby, is that a thing you want to see fixed somewhat in the near future?
Flags: needinfo?(bobbyholley)
Reporter | ||
Comment 5•6 years ago
|
||
(In reply to Henrik Skupin (:whimboo) from comment #4)
> Hi Bobby, is that a thing you want to see fixed somewhat in the near future?
Yes, though I'm unlikely to get to it in the next few weeks.
I don't think this needs to block bug 1274251 though. You can just set wantXrays to false in all your sandboxes, which will give you the new behavior, and is one of the things we'd need to do to get this bug landed anyway.
Flags: needinfo?(bobbyholley)
Reporter | ||
Comment 6•6 years ago
|
||
And for the sandboxes where you're currently relying on it to get Xray vision, you should use an Expanded Principal [1] instead.
[1] https://developer.mozilla.org/en-US/docs/Mozilla/Gecko/Script_security#Expanded_principal
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•