Closed
Bug 1491975
Opened 6 years ago
Closed 6 years ago
[wdspec] tests/new_session/platform_name.py | AttributeError: 'skip_if' not a registered marker
Categories
(Testing :: geckodriver, defect, P2)
Tracking
(firefox63 fixed, firefox64 fixed)
RESOLVED
FIXED
mozilla64
People
(Reporter: whimboo, Assigned: whimboo)
References
Details
(Keywords: regression)
Attachments
(1 file)
|
(deleted),
patch
|
ato
:
review+
|
Details | Diff | Splinter Review |
The test used the following marker:
> @pytest.mark.skip_if(platform_name is None, reason="Unsupported platform {}".format(platform_name))
This is not defined in pytest. Instead it should be `skipif()`.
|
Assignee | |
Comment 1•6 years ago
|
||
Attachment #9009866 -
Flags: review?(ato)
|
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•6 years ago
|
Priority: P3 → P2
|
||
Updated•6 years ago
|
Attachment #9009866 -
Flags: review?(ato) → review+
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/996edeaa6537
[wdspec] Fix pytest marker for skipif. r=ato
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/13074 for changes under testing/web-platform/tests
Can't merge web-platform-tests PR due to failing upstream checks:
Github PR https://github.com/web-platform-tests/wpt/pull/13074
* continuous-integration/travis-ci/pr (https://travis-ci.org/web-platform-tests/wpt/builds/430558839?utm_source=github_status&utm_medium=notification)
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
|
||
Comment 6•6 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Upstream PR merged
Can't merge web-platform-tests PR due to failing upstream checks:
Github PR https://github.com/web-platform-tests/wpt/pull/13074
* Taskcluster (pull_request) (https://tools.taskcluster.net/task-group-inspector/#/OeDmaPaGTdqniz1-FSoT9w)
|
|
||
Comment 9•6 years ago
|
||
Possible wpt-sync bug that it complains the PR can’t be merged
due to failing upsteam tests when the PR has already been merged
20 minutes prior?
Flags: needinfo?(james)
|
|
Assignee | |
Comment 10•6 years ago
|
||
There was a network issue, but I don't see that the tests have been run again. So maybe a sync bug.
https://tools.taskcluster.net/groups/OeDmaPaGTdqniz1-FSoT9w/tasks/OtVDIn8iSAaHuywSv8Tw4g/runs/0/logs/public%2Flogs%2Flive.log
|
|
Assignee | |
Comment 11•6 years ago
|
||
It's actually a regression from bug 1470659. So please uplift this test only patch to beta. Thanks!
Blocks: 1470659
status-firefox63:
--- → affected
Keywords: regression
Whiteboard: [checkin-needed-beta]
|
||
Comment 12•6 years ago
|
||
| bugherder uplift | ||
|
|
||
Updated•6 years ago
|
Whiteboard: [checkin-needed-beta]
|
||
Updated•6 years ago
|
Flags: needinfo?(james)
You need to log in
before you can comment on or make changes to this bug.
Description
•