Comment on attachment 9010030 [details] [diff] [review] patch I don't see screenshots results for Windows yet, but r=me if they are fine. Thanks!

(In reply to :Paolo Amadini from comment #2) > Comment on attachment 9010030 [details] [diff] [review] > patch > > I don't see screenshots results for Windows yet, but r=me if they are fine. > Thanks! The build failed randomly. New push: https://screenshots.mattn.ca/compare/?oldProject=try&oldRev=b0834b9fa59354fc633e5d5ee868ed5c97759e94&newProject=try&newRev=79ad9d62cead0fdec847291fcea2ee573696ae5f&filter=windows There seems to be a minor difference with .identity-popup-preferences-button's vertical alignment in the control center, but that's not necessarily a bug. Anyway, I can look into that in a followup if needed.

Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/5d63a6222e9e Load toolbarbutton.css as a document stylesheet. r=paolo

(In reply to Dão Gottwald [::dao] from comment #3) > There seems to be a minor difference with > .identity-popup-preferences-button's vertical alignment in the control > center, but that's not necessarily a bug. Anyway, I can look into that in a > followup if needed. That small change looks fine to me. Johann?

Backed out changeset 5d63a6222e9e (Bug 1492130) for chrome-mochitest failures on toolkit/content/tests/chrome/test_bug562554.xul. Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/b7028c988cd4ad7d5a877ef82127256f9c506d99 Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=success,testfailed,busted,exception&revision=5d63a6222e9e5bfa226c7a54ea69e2ba2096e2f6&selectedJob=200166823 Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=200166823&repo=mozilla-inbound&lineNumber=4553

The debug-mochitest (ay11) are also failing on this push: accessible/tests/mochitest/hittest/test_menu.xul https://treeherder.mozilla.org/logviewer.html#?job_id=200167493&repo=mozilla-inbound&lineNumber=3564

test_bug562554.xul fixed. > The debug-mochitest (ay11) are also failing on this push: > accessible/tests/mochitest/hittest/test_menu.xul > https://treeherder.mozilla.org/logviewer.html#?job_id=200167493&repo=mozilla- > inbound&lineNumber=3564 Interestingly, that test doesn't even use toolbarbuttons...

(In reply to :Paolo Amadini from comment #5) > (In reply to Dão Gottwald [::dao] from comment #3) > > There seems to be a minor difference with > > .identity-popup-preferences-button's vertical alignment in the control > > center, but that's not necessarily a bug. Anyway, I can look into that in a > > followup if needed. > > That small change looks fine to me. Johann? Yeah, judging by the screenshot it might be fine, would have to look at it in the context of the other UI items to be sure, but I agree it's not necessarily a bug.

(In reply to Dão Gottwald [::dao] from comment #8) > > The debug-mochitest (ay11) are also failing on this push: > > accessible/tests/mochitest/hittest/test_menu.xul > > https://treeherder.mozilla.org/logviewer.html#?job_id=200167493&repo=mozilla- > > inbound&lineNumber=3564 > > Interestingly, that test doesn't even use toolbarbuttons... Alexander, any idea what's going on with these a11y tests? Why would they be affected by this patch when they don't even have XUL toolbarbutton elements? https://treeherder.mozilla.org/#/jobs?repo=try&revision=29c333cdfb8c39e53e4121b10642bd9990219217

(In reply to Dão Gottwald [::dao] from comment #10) > (In reply to Dão Gottwald [::dao] from comment #8) > > > The debug-mochitest (ay11) are also failing on this push: > > > accessible/tests/mochitest/hittest/test_menu.xul > > > https://treeherder.mozilla.org/logviewer.html#?job_id=200167493&repo=mozilla- > > > inbound&lineNumber=3564 > > > > Interestingly, that test doesn't even use toolbarbuttons... > > Alexander, any idea what's going on with these a11y tests? Why would they be > affected by this patch when they don't even have XUL toolbarbutton elements? > > https://treeherder.mozilla.org/#/ > jobs?repo=try&revision=29c333cdfb8c39e53e4121b10642bd9990219217 Yeah, a weird one. It seems it fails to open/close a submenu properly (https://dxr.mozilla.org/mozilla-central/source/accessible/tests/mochitest/states/test_visibility.xul?q=test_visibility.xul&redirect_type=direct#137). Is there any chance that tooolbarbutton styles are interfered somehow with menu styles? Does anything weird happen visually?

(In reply to alexander :surkov (:asurkov) from comment #11) > (In reply to Dão Gottwald [::dao] from comment #10) > > (In reply to Dão Gottwald [::dao] from comment #8) > > > > The debug-mochitest (ay11) are also failing on this push: > > > > accessible/tests/mochitest/hittest/test_menu.xul > > > > https://treeherder.mozilla.org/logviewer.html#?job_id=200167493&repo=mozilla- > > > > inbound&lineNumber=3564 > > > > > > Interestingly, that test doesn't even use toolbarbuttons... > > > > Alexander, any idea what's going on with these a11y tests? Why would they be > > affected by this patch when they don't even have XUL toolbarbutton elements? > > > > https://treeherder.mozilla.org/#/ > > jobs?repo=try&revision=29c333cdfb8c39e53e4121b10642bd9990219217 > > Yeah, a weird one. It seems it fails to open/close a submenu properly > (https://dxr.mozilla.org/mozilla-central/source/accessible/tests/mochitest/ > states/test_visibility.xul?q=test_visibility.xul&redirect_type=direct#137). > Is there any chance that tooolbarbutton styles are interfered somehow with > menu styles? Does anything weird happen visually? Found the problem: the menupopup binding has an anonymous arrowscrollbox, the arrowscrollbox scroll buttons are toolbarbuttons, and they get a different size with this patch applied.

Comment on attachment 9010907 [details] [diff] [review] patch v3 Cool, thanks!

Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/ced8a51eff4a Load toolbarbutton.css and scrollbox.css as document stylesheets. r=paolo

Backed out changeset ced8a51eff4a (Bug 1492130) for wpt failures in css/css-shapes/shape-outside/values/shape-outside-shape-arguments-000.html Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed,busted,exception&classifiedState=unclassified&revision=ced8a51eff4a4ef0fc19df19e0cfa74ed0b87a09&selectedJob=200729590 Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=200729590&repo=mozilla-inbound&lineNumber=1875 Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/0b594ee147e9f439871bd4b9b82e1b7ec6a43fc7

Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/ff7f29fad49c Load toolbarbutton.css and scrollbox.css as document stylesheets. r=paolo