Closed
Bug 1494204
Opened 6 years ago
Closed 6 years ago
Hovering disabled .subviewbutton should not change text color
Categories
(Firefox :: Theme, defect, P1)
Tracking
()
RESOLVED
FIXED
Firefox 64
Tracking | Status | |
---|---|---|
firefox-esr60 | --- | unaffected |
firefox62 | --- | unaffected |
firefox63 | --- | unaffected |
firefox64 | --- | fixed |
People
(Reporter: ntim, Assigned: dao)
References
Details
(Keywords: regression)
Attachments
(2 files)
(deleted),
image/png
|
Details | |
(deleted),
patch
|
ntim
:
review+
|
Details | Diff | Splinter Review |
Either [0] needs an !important, either [1] should be removed.
[0]: https://searchfox.org/mozilla-central/source/browser/themes/shared/customizableui/panelUI.inc.css#875
[1]: https://searchfox.org/mozilla-central/source/toolkit/themes/osx/global/toolbarbutton.css#22-27
Reporter | ||
Updated•6 years ago
|
status-firefox64:
--- → affected
Keywords: regression
Reporter | ||
Updated•6 years ago
|
Component: General → Theme
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
OS: Unspecified → Mac OS X
Priority: -- → P1
Assignee | ||
Comment 1•6 years ago
|
||
Attachment #9012082 -
Flags: review?(ntim.bugs)
Reporter | ||
Comment 2•6 years ago
|
||
Comment on attachment 9012082 [details] [diff] [review]
patch
Review of attachment 9012082 [details] [diff] [review]:
-----------------------------------------------------------------
Fixes the issue for me, thanks!
Attachment #9012082 -
Flags: review?(ntim.bugs) → review+
Reporter | ||
Updated•6 years ago
|
Keywords: checkin-needed
Pushed by nerli@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9fcae361b337
Remove redundant selectors from toolbarbutton[disabled] rule. r=ntim
Keywords: checkin-needed
Comment 4•6 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
Updated•6 years ago
|
status-firefox62:
--- → unaffected
status-firefox63:
--- → unaffected
status-firefox-esr60:
--- → unaffected
You need to log in
before you can comment on or make changes to this bug.
Description
•