Thunderbird runs all toolkit Xpcshell tests and now the ones from toolkit/components/places/tests/unifiedcomplete/ all fail. This appears to come from bug 1489282 or bug 1490527 which made those tests use a new file browser/components/urlbar/UrlbarPrefs.jsm. Surprisingly the logs show: "CONSOLE_MESSAGE: (error) [JavaScript Error: "NS_ERROR_FILE_NOT_FOUND: " {file: "jar:file:///Users/cltbld/tasks/task_1537334919/build/application/Thunderbird%20Daily.app/Contents/Resources/omni.ja!/components/UnifiedComplete.js" line: 2325}]" Marco and Drew, how can we resolve this? Turn off the entire test directory for TB? Or make some adjustments at your end? Additionally to the unifiedcomplete test, these now also fail: TEST-UNEXPECTED-FAIL | toolkit/components/places/tests/unit/test_413784.js TEST-UNEXPECTED-FAIL | toolkit/components/places/tests/unit/test_408221.js TEST-UNEXPECTED-FAIL | toolkit/components/places/tests/unit/test_000_frecency.js TEST-UNEXPECTED-FAIL | toolkit/components/places/tests/unit/test_frecency.js TEST-UNEXPECTED-FAIL | tools/profiler/tests/test_enterjit_osr.js

This was my fear, we actually plan to move the unifiedcomplete component to browser/ so it won't affect your anymore.

ETA for that? I have permanent failures on the tree now :-(

if you wish to make a patch to exclude the unifiedcomplete test folder for you, we can take it sooner.

I'll do that, but there are some more, see comment #0. What are they about? We switched off some "frecency" tests in bug 1482627 and bug 1482085.

I ran toolkit/components/places/tests/unit/test_413784.js toolkit/components/places/tests/unit/test_408221.js toolkit/components/places/tests/unit/test_000_frecency.js toolkit/components/places/tests/unit/test_frecency.js manually and they all failed with JavaScript Error: "NS_ERROR_FILE_NOT_FOUND: ... UnifiedComplete.js" So I switched those off as well. I don't quite understand the error since UnifiedComplete.js is still available at: https://hg.mozilla.org/mozilla-central/log/tip/toolkit/components/places/UnifiedComplete.js

Forgot to mention Thunderbird in the commit message.

(In reply to Jorg K (GMT+2) from comment #5) > manually and they all failed with > JavaScript Error: "NS_ERROR_FILE_NOT_FOUND: ... UnifiedComplete.js" > > So I switched those off as well. I don't quite understand the error since > UnifiedComplete.js is still available at: > https://hg.mozilla.org/mozilla-central/log/tip/toolkit/components/places/ > UnifiedComplete.js I think if you look at the full error: "CONSOLE_MESSAGE: (error) [JavaScript Error: "NS_ERROR_FILE_NOT_FOUND: " {file: "jar:file:///Z:/task_1537356921/build/application/thunderbird/omni.ja!/components/UnifiedComplete.js" line: 2325}]" Then it is saying that there's a file not found which is triggered on line 2325 of UnifiedComplete.js. That line is using UrlbarPrefs, which is a lazy getter which loads the newly added UrlbarPrefs.js that's under browser. For info, bug 1492226 is the already filed bug for moving UnifiedComplete.js across to browser/.

Thanks for looking at it thoroughly, Mark!

Comment on attachment 9010205 [details] [diff] [review] 1492379-switch-off-tests.patch Review of attachment 9010205 [details] [diff] [review]: ----------------------------------------------------------------- those tests checks how frecency influences unifiedcomplete, so it's ok to disable them and we should move them to the urlbar component along with the unifiedcomplete component. Thank you!

Thanks for your help and the quick turnaround.

Pushed by nbeleuzu@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/db8fbd7e55fc Switch off tests in unifiedcomplete and four more all depending on UnifiedComplete.js for Thunderbird. r=mak

Sorry about this, I didn't realize it might break tests on Thunderbird but of course now it's obvious.