test-plugin-crashing.js is a real joy, see bug 1211005 and bug 1307516. Lately we're seeing this on Windows: EST-UNEXPECTED-FAIL | Z:\task_1537818046\build\tests\mozmill\content-tabs\test-plugin-crashing.js | test-plugin-crashing.js::test_can_crash_plugin TEST-UNEXPECTED-FAIL | Z:\task_1537818046\build\tests\mozmill\content-tabs\test-plugin-crashing.js | test-plugin-crashing.js::test_crashed_plugin_notification_bar TEST-UNEXPECTED-FAIL | Z:\task_1537818046\build\tests\mozmill\content-tabs\test-plugin-crashing.js | test-plugin-crashing.js::test_crashed_plugin_notification_inline The log https://taskcluster-artifacts.net/AlO-WQbbTfqmSNFxnDn2Ow/0/public/logs/live_backing.log says that the file is locked, so Aceman already has a patch cooking: https://hg.mozilla.org/try-comm-central/rev/9ab69c91b05a650beb5f83af04e0b1027f14aa53 INFO - SUMMARY-UNEXPECTED-FAIL | Z:\task_1537818046\build\tests\mozmill\content-tabs\test-plugin-crashing.js | test-plugin-crashing.js::test_can_crash_plugin INFO - EXCEPTION: Component returned failure code: 0x8052000e (NS_ERROR_FILE_IS_LOCKED) [nsIFile.remove] INFO - at: nonesuch line 159 INFO - PluginCrashObserver_removeMinidump test-plugin-crashing.js:159 7 INFO - observe test-plugin-crashing.js:136 7 INFO - waitFor utils.js:427 5 INFO - MozMillController.prototype.waitFor controller.js:687 3 INFO - waitForCrash test-plugin-crashing.js:125 7 INFO - crash_plugin test-plugin-crashing.js:173 5 INFO - test_can_crash_plugin test-plugin-crashing.js:183 15

If the dump file is locked, retry for a while until the writer unlocks it (closes it) so we can remove it on Windows. Try run: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=b466a3374044f627a47b0c90fe7f7b39da2eb01f

Comment on attachment 9011633 [details] [diff] [review] 1493807.patch Review of attachment 9011633 [details] [diff] [review]: ----------------------------------------------------------------- Very nice, let's give this a go. Maybe add // Yield to the event loop while waiting for the file to get unlocked. before the sleep(0).

Pushed by acelists@atlas.sk: https://hg.mozilla.org/comm-central/rev/ed39f5376968 Wait for crash reporter dump file to become unlocked before deleting it in test-plugin-crashing.js. r=jorgk