Closed Bug 1495163 Opened 6 years ago Closed 6 years ago

blob invalidation: SVG animation issues

Categories

(Core :: Graphics: WebRender, defect, P4)

64 Branch
Unspecified
All
defect

Tracking

()

RESOLVED WORKSFORME
Tracking Status
geckoview62 --- unaffected
firefox-esr60 --- unaffected
firefox62 --- disabled
firefox63 --- disabled
firefox64 --- disabled
firefox65 --- disabled
firefox66 --- disabled

People

(Reporter: 709922234, Unassigned)

References

(Blocks 1 open bug, )

Details

(Keywords: nightly-community, regression)

Attachments

(3 files)

Attached image Screen Shot 2018-09-29 at 11.33.29.png (deleted) —
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:64.0) Gecko/20100101 Firefox/64.0 Build ID: 20180928220433 Steps to reproduce: 1. open https://x.yupoo.com/ 2. scroll page Actual results: svg has the wrong color block
Component: Untriaged → Graphics: WebRender
Product: Firefox → Core
Thanks!
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Unspecified → All
Priority: -- → P3
Attached file lazy.html (deleted) —
* There is no smooth transition/fade in of the green points when not moving the mouse * SVG icons can be highly pixelated at first * Sometimes there is a light green box like seen in attachment 9013061 [details] that grows to the size of the whole circle and disappears
(The whole thing ran into bug 1455841 (2018-04-20). Same regression and fix range. Today's three issues already existed before.) first bad = all three issues mozregression --good 2018-01-15 --bad 2018-04-19 --pref gfx.webrender.all:true -a https://bug1495163.bmoattachments.org/attachment.cgi?id=9013107 > 40:22.30 INFO: Last good revision: 38cfaf35c4c1b2761c97c78769496b3181a6eedc > 40:22.30 INFO: First bad revision: 2a2282923b5abdf8b95bad5a59e694ac8e744883 > 40:22.30 INFO: Pushlog: > https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=38cfaf35c4c1b2761c97c78769496b3181a6eedc&tochange=2a2282923b5abdf8b95bad5a59e694ac8e744883 > 2a2282923b5a Jeff Muizelaar — Bug 1450015. Enable blob invalidation by default. r=gankro
Blocks: 1450015
Has Regression Range: --- → yes
Keywords: regression
Summary: when webrender is enabled is svg animation error → blob invalidation: when webrender is enabled is svg animation error
Attached video 2018-09-29_20-35-42.mp4 (deleted) —
Summary: blob invalidation: when webrender is enabled is svg animation error → blob invalidation: SVG animation issues
Marking fix-optional for 64. We could still take a patch for 65, and if it's verified and doesn't seem risky, could still take fixes for 64 as well.
Priority: P3 → P2
I think this might be related to the scale stuff.
Assignee: nobody → tnikkel
Flags: needinfo?(jmuizelaar)
(In reply to Jeff Muizelaar [:jrmuizel] from comment #6) > I think this might be related to the scale stuff. The patch from bug 1415987 does fix the obvious problems here, but I'm not sure if there are still smaller, less frequent glitches of a different type.
Flags: needinfo?(jmuizelaar)
:darkspirit, do you still see anything wrong here?
Flags: needinfo?(jan)
All issues from comment 2 seem to be fixed. I'll file a separate bug about a regression causing the circle to flicker. mozregression --find-fix --bad 2018-09-29 --good 2018-12-24 --pref gfx.webrender.all:true -a https://bug1495163.bmoattachments.org/attachment.cgi?id=9013107 > 21:38.60 INFO: First good revision: 996bf60e0fce90cc42e7b59201d56ba0947b8cf2 > 21:38.60 INFO: Last bad revision: f1ce520b1d0d0223ee117796ead6551881ec4fc6 > 21:38.60 INFO: Pushlog: > https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=f1ce520b1d0d0223ee117796ead6551881ec4fc6&tochange=996bf60e0fce90cc42e7b59201d56ba0947b8cf2 > 996bf60e0fce Timothy Nikkel — Bug 1415987. Use ChooseScale to choose a scale in WebRender. r=jrmuizel > 640e15aa79b9 Jeff Muizelaar — Bug 1415987. Factor out ChooseScale from ChooseScaleAndSetTransform in FrameLayerBuilder. r=tnikkel
Status: NEW → RESOLVED
Closed: 6 years ago
Depends on: 1415987
Flags: needinfo?(jan)
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
(In reply to Jan Andre Ikenmeyer [:darkspirit] from comment #9) > I'll file a separate bug about a regression causing the circle to flicker. 1. Actually, that bug was present before.. Just press F5 often. Sometimes the circle will flash white. 2. If you zoom in by Ctrl+mousewheel while the animation is running, lines of the circle are misplaced. Does not happen without WebRender.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: mozilla66 → ---
I couldn't reproduce the issues from comment 10 on Win10/GTX1060, but on Debian Testing/X11/Macbook Pro. Maybe it could still be reproducible on Win10 with older/weaker Nvidia cards?
Priority: P2 → P4
Assignee: tnikkel → nobody

Closing. Please reopen if there's still an issue here.

Status: REOPENED → RESOLVED
Closed: 6 years ago6 years ago
Resolution: --- → FIXED
Resolution: FIXED → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: