Used the custom element approach, because the object approach will be unpleasant like we saw while converting statuspanel.

Comment on attachment 9016674 [details] [diff] [review] mail-emailheaderfield.patch Review of attachment 9016674 [details] [diff] [review]: ----------------------------------------------------------------- Unless this is on top of another patch, the context menu "Add To Address Book" is broken by this patch. https://searchfox.org/comm-central/source/mail/base/content/mainPopupSet.inc#1172

I ll try to first land the mail-emailaddress patch then work on this..

(In reply to Magnus Melin [:mkmelin] from comment #2) > Comment on attachment 9016674 [details] [diff] [review] > mail-emailheaderfield.patch > > Review of attachment 9016674 [details] [diff] [review]: > ----------------------------------------------------------------- > > Unless this is on top of another patch, the context menu "Add To Address > Book" is broken by this patch. > https://searchfox.org/comm-central/source/mail/base/content/mainPopupSet. > inc#1172 hey how do i test email-headerfield? It is only inside #expandedSenderrow which remains collapsed for all the emails that i have. how do i send an email to myself that have an sender field?

Easiest to just go into the profile and modify the mail file. (Details on irc.)

(In reply to Magnus Melin [:mkmelin] from comment #2) > Comment on attachment 9016674 [details] [diff] [review] > mail-emailheaderfield.patch > > Review of attachment 9016674 [details] [diff] [review]: > ----------------------------------------------------------------- > > Unless this is on top of another patch, the context menu "Add To Address > Book" is broken by this patch. > https://searchfox.org/comm-central/source/mail/base/content/mainPopupSet. > inc#1172 it is not due to this patch.. you can check it on default branch, same issue is still there. I ll try to fix this in this patch. LOoks like the newItemAdded evvent is not fired when address is added. https://searchfox.org/comm-central/source/mail/base/content/msgHdrView.js#1568 this line is executed even for sender's emailaddress but the newItemAdded event is never fired.

Comment on attachment 9021744 [details] [diff] [review] mail-emailheaderfield.patch Review of attachment 9021744 [details] [diff] [review]: ----------------------------------------------------------------- Yeah this works, although it's a bit heavy weight as a CE as it does very little. But we can fix that later after the multi email case is also done. r=mkmelin

Need to rebase first..

Applied cleanly to a new checkout for me

linux - https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=f5b181cd08d42c0c036b0e2fc16e85838ff5e962

Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/cffa7cb63305 Remove mail-emailheaderfield binding. r=mkmelin

The friendly sheriff rebased this after bug 1502988 :-)