Closed Bug 1499852 Opened 6 years ago Closed 6 years ago

Platform sort order is no longer alphabetical

Categories

(Tree Management :: Treeherder: Frontend, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: RyanVM, Assigned: camd)

References

Details

Attachments

(2 files)

Attached image screenshot (deleted) —
This is a recent regression. Looks like upper vs. lower case is affecting sort order or something?
I can reproduce when using the right type of push. Bisecting locally this starts as of bug 1450040, however the sort order before was not alphabetical (but related platforms were at least adjacent). STR: 1) Visit a push that has most of the platforms present, eg: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=6b952be63f69e244ab688cdb7a84d121b009a162 2) Look at sort order of platforms Expected: All "Windows ..." platforms to be on adjacent rows. Actual: A handful of "Windows ..." platform rows, followed by Android/Gecko/..., then finally the rest of the "Windows ..." platforms.
Blocks: 1450040
Flags: needinfo?(cdawson)
Assignee: nobody → cdawson
Status: NEW → ASSIGNED
Flags: needinfo?(cdawson)
We were missing the "all" option in the thOptionOrder map.
Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/175f53e99a0fca053ab3fd8b78dfff01d7249f7a Bug 1499852 - Add missing option to fix platform sort order (#4165) the option of "all" was missing from the map object. I also added a fall-back in case another option comes our way that doesn't exist.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: