Closed Bug 1499866 Opened 6 years ago Closed 6 years ago

Green up wpt compat directory on fennec

Categories

(Testing :: web-platform-tests, defect)

Version 3
defect
Not set
normal

Tracking

(firefox65 fixed)

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: KWierso, Assigned: KWierso)

References

Details

Attachments

(4 files)

https://docs.google.com/spreadsheets/d/1rCCtVHqzRGfWUg80EBQRbHgHiasNNrtk3erBBmSAvP0/edit?usp=sharing These tests have some unexpected passes and some unexpected failures. The passes probably just need updated metadata (fennec supports the "orientation" attributes and properties, so they show up in the tests). I'm not so sure about the failures. It looks like it's checking if some -webkit-appearance prefixed stuff are supported, and it doesn't find them. That's confusing to me, because I thought they were enabled by default for fennec, and Bug 1488001 explicitly flipped the pref to enable them for wpt tests (and I see in the test log a line saying "Setting pref layout.css.webkit-appearance.enabled (true)", so I assume it actually sets the pref).
Fennec supports orientation attributes and properties, so these were unexpectedly passing.
Assignee: nobody → wkocher
Pushed by wkocher@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9db2b627026f Update wpt metadata for idlharness.window.js on fennec r=jgraham
:jwatt, Mike pointed me to you to see if these issues are known. For context, these are being run off of builds from mozilla-central, so should be picking things up from bug 1480073's EARLY_BETA_OR_EARLIER. The "layout.css.webkit-appearance.enabled" preference is also being explicitly set to 'true', so I would think the webkit-prefixed things should be working. Am I missing something?
Flags: needinfo?(miket)
Flags: needinfo?(jwatt)
For reference, the failures I'm talking about are: Unexpected Results ------------------ /compat/webkit-appearance.html FAIL -webkit-appearance: button - assert_equals: expected "button" but got "none" @http://web-platform.test:8000/compat/webkit-appearance.html:32:7 Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1561:20 test@http://web-platform.test:8000/resources/testharness.js:544:21 @http://web-platform.test:8000/compat/webkit-appearance.html:26:5 FAIL -webkit-appearance: button-bevel - assert_equals: expected "button-bevel" but got "none" @http://web-platform.test:8000/compat/webkit-appearance.html:32:7 Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1561:20 test@http://web-platform.test:8000/resources/testharness.js:544:21 @http://web-platform.test:8000/compat/webkit-appearance.html:26:5 FAIL -webkit-appearance: caret - assert_equals: expected "caret" but got "none" @http://web-platform.test:8000/compat/webkit-appearance.html:32:7 Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1561:20 test@http://web-platform.test:8000/resources/testharness.js:544:21 @http://web-platform.test:8000/compat/webkit-appearance.html:26:5 FAIL -webkit-appearance: checkbox - assert_equals: expected "checkbox" but got "none" @http://web-platform.test:8000/compat/webkit-appearance.html:32:7 Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1561:20 test@http://web-platform.test:8000/resources/testharness.js:544:21 @http://web-platform.test:8000/compat/webkit-appearance.html:26:5 FAIL -webkit-appearance: listbox - assert_equals: expected "listbox" but got "none" @http://web-platform.test:8000/compat/webkit-appearance.html:32:7 Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1561:20 test@http://web-platform.test:8000/resources/testharness.js:544:21 @http://web-platform.test:8000/compat/webkit-appearance.html:26:5 FAIL -webkit-appearance: listitem - assert_equals: expected "listitem" but got "none" @http://web-platform.test:8000/compat/webkit-appearance.html:32:7 Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1561:20 test@http://web-platform.test:8000/resources/testharness.js:544:21 @http://web-platform.test:8000/compat/webkit-appearance.html:26:5 FAIL -webkit-appearance: menulist - assert_equals: expected "menulist" but got "none" @http://web-platform.test:8000/compat/webkit-appearance.html:32:7 Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1561:20 test@http://web-platform.test:8000/resources/testharness.js:544:21 @http://web-platform.test:8000/compat/webkit-appearance.html:26:5 FAIL -webkit-appearance: menulist-button - assert_equals: expected "menulist-button" but got "none" @http://web-platform.test:8000/compat/webkit-appearance.html:32:7 Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1561:20 test@http://web-platform.test:8000/resources/testharness.js:544:21 @http://web-platform.test:8000/compat/webkit-appearance.html:26:5 FAIL -webkit-appearance: menulist-text - assert_equals: expected "menulist-text" but got "none" @http://web-platform.test:8000/compat/webkit-appearance.html:32:7 Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1561:20 test@http://web-platform.test:8000/resources/testharness.js:544:21 @http://web-platform.test:8000/compat/webkit-appearance.html:26:5 FAIL -webkit-appearance: menulist-textfield - assert_equals: expected "menulist-textfield" but got "none" @http://web-platform.test:8000/compat/webkit-appearance.html:32:7 Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1561:20 test@http://web-platform.test:8000/resources/testharness.js:544:21 @http://web-platform.test:8000/compat/webkit-appearance.html:26:5 FAIL -webkit-appearance: radio - assert_equals: expected "radio" but got "none" @http://web-platform.test:8000/compat/webkit-appearance.html:32:7 Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1561:20 test@http://web-platform.test:8000/resources/testharness.js:544:21 @http://web-platform.test:8000/compat/webkit-appearance.html:26:5 FAIL -webkit-appearance: searchfield - assert_equals: expected "searchfield" but got "none" @http://web-platform.test:8000/compat/webkit-appearance.html:32:7 Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1561:20 test@http://web-platform.test:8000/resources/testharness.js:544:21 @http://web-platform.test:8000/compat/webkit-appearance.html:26:5 FAIL -webkit-appearance: textfield - assert_equals: expected "textfield" but got "none" @http://web-platform.test:8000/compat/webkit-appearance.html:32:7 Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1561:20 test@http://web-platform.test:8000/resources/testharness.js:544:21 @http://web-platform.test:8000/compat/webkit-appearance.html:26:5 FAIL -webkit-appearance: bogus-button (invalid) - assert_equals: expected "button" but got "none" @http://web-platform.test:8000/compat/webkit-appearance.html:45:7 Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1561:20 test@http://web-platform.test:8000/resources/testharness.js:544:21 @http://web-platform.test:8000/compat/webkit-appearance.html:39:5
Yeah, it seems like we have a difference between Fennec and desktop in what the CSSStyleDeclaration from getComputedStyle returns: var f = document.createElement("button") f.style["-webkit-appearance"] = "button" var computed = getComputedStyle(f).WebkitAppearance On desktop, computed will be "button" and on Fennec, it will be "none". (relatedly, it's kinda surprising that when I set -webkit-appearance, "-moz-appearance" is set, but maybe that's a devtools bug?).
Flags: needinfo?(miket)
Attached image Fennec (deleted) —
Attached image Desktop (deleted) —
The styles used in these tests are being explicitly overwritten on mobile Firefox, and that isn't likely to change for the foreseeable future. Just mark them as expected failures on android for now to green things up a bit.
Pushed by wkocher@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bc93ef323aa2 Update metadata for wpt compat directory r=miketaylr
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: