Closed Bug 1502150 Opened 6 years ago Closed 5 years ago

getComputedStyle difference between Fennec and Desktop (at least for WebkitAppearance values)

Categories

(Core :: Layout, defect, P3)

Product:
Core
Component:
Layout
Version:
63 Branch
Type:
defect

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1618202
Tracking Flags:
Tracking Status
firefox-esr60 --- wontfix
firefox-esr68 --- wontfix
firefox68 --- wontfix
firefox69 --- wontfix
firefox70 --- affected
firefox71 --- affected

People

(Reporter: miketaylr, Unassigned)

References

Details

(Whiteboard: [webcompat] [layout:triage-discuss])

Attachments

(1 file)

computed-appearance.html
(deleted), text/html
Details
Attached file computed-appearance.html (deleted) —
STR: In Fennec and Desktop, open the test case. Expected: See PASS (which is what I see in Desktop) Actual: In Fennec, I get FAIL in Nightly 65. For convenience, here's the content of the test case: var f = document.createElement("button") f.style["-webkit-appearance"] = "button" var computed = getComputedStyle(f).WebkitAppearance if (computed == "button") { document.write("PASS"); } else { document.write("FAIL"); }
Flags: needinfo?(jwatt)
Whiteboard: [webcompat]
FWIW, Firefox Focus with Geckoview also shows FAIL in that test case.
Emilio, are we taking different code paths for style for fennec for some reason?
Flags: needinfo?(jwatt) → needinfo?(emilio)
Nope, most likely this: https://searchfox.org/mozilla-central/rev/e0c879c86b95bdc752b1dbff6088169735674e4a/mobile/android/themes/geckoview/content.css#97 I don't know who maintains those stylesheets, but they're somewhat broken... See also bug 1470709 for an example.
Flags: needinfo?(emilio)
Component: DOM → Widget: Android

Migrating Webcompat whiteboard priorities to project flags. See bug 1547409.

Webcompat Priority: --- → ?

See bug 1547409. Migrating whiteboard priority tags to program flags.

Webcompat Priority: ? → ---
Component: Widget: Android → General
Priority: -- → P2
Product: Core → GeckoView
Whiteboard: [webcompat] → [geckoview][webcompat]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #3)

https://searchfox.org/mozilla-central/rev/
e0c879c86b95bdc752b1dbff6088169735674e4a/mobile/android/themes/geckoview/
content.css#97

I don't know who maintains those stylesheets, but they're somewhat broken...
See also bug 1470709 for an example.

Emilio, who do you think should maintain these Android content stylesheets? The Gecko Layout/CSS team? A mobile UX designer?

Flags: needinfo?(emilio)
Whiteboard: [geckoview][webcompat] → [webcompat]

Probably the layout team, but I don't know why the stylesheets look like they do right right now. Most of them look like workarounds for form control issues that should be fixed by the android folks.

Flags: needinfo?(emilio)

stylesheets ... workarounds for form control issues that should be fixed by the android folks.

Removing bug priority to send bug back to GV triage for discussion of these form control issues.

Probably the layout team, but I don't know why the stylesheets look like they do right right now.

And whether we should move this bug from the GeckoView component to Layout.

status-firefox68: --- → wontfix
status-firefox69: --- → affected
status-firefox70: --- → affected
status-firefox-esr60: --- → wontfix
status-firefox-esr68: --- → affected
Priority: P2 → --

Moving from GeckoView's Bugzilla component to Layout because this is a layout webcompat issue.

I'm not sure which team should be responsible for deciding what Gecko's Android content stylesheets should look like. The Layout engineering team? The GeckoView engineer team? A Fenix product manager or UX designer?

firefox-esr68=wontfix because we wouldn't uplift a fix for this bug to Fennec ESR 68.

status-firefox69: affected → wontfix
status-firefox71: --- → affected
status-firefox-esr68: affected → wontfix
Component: General → Layout
Product: GeckoView → Core
Whiteboard: [webcompat] → [webcompat] [layout:triage-discuss]

The priority flag is not set for this bug.
:kamidphish, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(dglastonbury)
Flags: needinfo?(dglastonbury)
Priority: -- → P3

This was fixed by bug 1618202.

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: