Closed
Bug 1500554
Opened 6 years ago
Closed 6 years ago
Have the session store listen for visual viewport scrolls
Categories
(Firefox for Android Graveyard :: Session Restore, defect, P1)
Firefox for Android Graveyard
Session Restore
Tracking
(firefox63 wontfix, firefox64 wontfix, firefox65 affected, firefox66 affected)
RESOLVED
DUPLICATE
of bug 1498812
People
(Reporter: JanH, Assigned: JanH)
References
Details
(Whiteboard: [geckoview:p3])
With pinch zooming, the visual viewport is what more accurately represents the user-visible scroll position, so the session store should update the scroll position as soon the visual viewport changes, not just on layout viewport scrolls.
In principle this affects Desktop as well, although in practice this only matters with pinch zooming. I'm going to try change both implementations anyway, though.
Comment 1•6 years ago
|
||
Cool, thanks! The idea is for Desktop to eventually get pinch-zooming as well (activated e.g. via the trackpad), so implementing things like this for Desktop as well will come in useful.
Jan is this something you're working on for 64? 65? Geckoview related?
Assignee | ||
Comment 3•6 years ago
|
||
Once I've done bug 1478776, and no, this particular bit doesn't affect the current Geckoview implementation.
Flags: needinfo?(jh+bugzilla)
Comment 4•6 years ago
|
||
CCing Sean for awareness, as the Layout team is currently doing some viewport work.
Comment 5•6 years ago
|
||
CC rhunt and hiro in case this is relevant to scroll anchoring (bug 1305957) in any way (or vice-versa)
Assignee | ||
Comment 6•6 years ago
|
||
(In reply to Jan Henning [:JanH] from comment #3)
> Once I've done bug 1478776, and no, this particular bit doesn't affect the
> current Geckoview implementation.
While GeckoView doesn't have anything like the current session store implementation, it does expose scroll events to Android consumers [1] and this might be another case where scrolls of the visual viewport might be the more interesting thing?
[1] https://dxr.mozilla.org/mozilla-central/rev/237e4c0633fda8e227b2ab3ab57e417c980a2811/mobile/android/chrome/geckoview/GeckoViewScrollChild.js#29
Updated•6 years ago
|
Assignee | ||
Updated•6 years ago
|
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → DUPLICATE
Assignee | ||
Updated•6 years ago
|
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•