Open
Bug 1501984
Opened 6 years ago
Updated 4 years ago
Use the React profiler to look for quick performance wins
Categories
(Tree Management :: Treeherder: Frontend, defect, P3)
Tree Management
Treeherder: Frontend
Tracking
(Not tracked)
NEW
People
(Reporter: emorley, Unassigned)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
https://reactjs.org/blog/2018/09/10/introducing-the-react-profiler.html
Notably it might help us spot cases where we should be using PureComponent or the new function equivalent, `React.memo()`:
https://reactjs.org/blog/2018/10/23/react-v-16-6.html#reactmemo
Reporter | ||
Comment 1•6 years ago
|
||
react-devtools currently makes the main job-view pages pretty unresponsive unless filtered down to only viewing one push.
I've filed:
https://github.com/facebook/react-devtools/issues/1200#issuecomment-437346433
Comment 2•6 years ago
|
||
Comment 3•6 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/3520515e2ab8f27ba4cf8141414fbfcd42ca8f57
Bug 1501984 - Fix too much re-rendering in App for url changes (#4353)
Updated•6 years ago
|
Assignee: nobody → cdawson
Comment 4•6 years ago
|
||
Comment 5•6 years ago
|
||
Reporter | ||
Comment 6•6 years ago
|
||
(In reply to Ed Morley [:emorley] from comment #1)
react-devtools currently makes the main job-view pages pretty unresponsive
unless filtered down to only viewing one push.I've filed:
https://github.com/facebook/react-devtools/issues/1200#issuecomment-437346433
The author of react-devtools replied to that issue with a few suggestions fwiw :-)
Updated•6 years ago
|
Priority: P3 → P2
Updated•6 years ago
|
No longer blocks: treeherder-react
Updated•6 years ago
|
Status: NEW → ASSIGNED
Updated•5 years ago
|
Type: enhancement → defect
Priority: P2 → P1
Updated•5 years ago
|
Priority: P1 → P3
Comment 7•4 years ago
|
||
I'm not going to do further work on this any time soon.
Assignee: cdawson → nobody
Status: ASSIGNED → NEW
You need to log in
before you can comment on or make changes to this bug.
Description
•