Closed Bug 1502525 Opened 6 years ago Closed 5 years ago

Consider reading extensions.webextensions.remote once

Categories

(WebExtensions :: General, enhancement, P3)

Product:
WebExtensions
Component:
General
Version:
64 Branch
Type:
enhancement

Tracking

(firefox74 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla74
Tracking Flags:
Tracking Status
firefox74 --- fixed

People

(Reporter: robwu, Assigned: robwu)

References

Details

Attachments

(3 files)

Bug 1502525 - Remove runtime changes to remote extension pref in mochitests
(deleted), text/x-phabricator-request
Details
Bug 1502525 - Test to verify that mochitests run with in-process extensions
(deleted), text/x-phabricator-request
Details
Bug 1502525 - Read extensions.webextensions.remote once
(deleted), text/x-phabricator-request
Details
Our code is not designed to account for changes to the extensions.webextensions.remote preference when an extension has started. Bug 1501375 is an example of a shutdown hang caused by an unexpected preference value flip. We should consider reading the preference value only once (at start-up), and fix our tests to not rely on the ability to flip the preference value at runtime.
Priority: -- → P2
Assignee: nobody → rob
Blocks: 1501375
Priority: P2 → P3

This pref is probably going to be removed soon, when we drop (testing) support for in-process WebExtensions.

(In reply to Rob Wu [:robwu] from comment #1)

This pref is probably going to be removed soon, when we drop (testing) support for in-process WebExtensions.

Do we have a bug on that, and is something for android blocking it?

The devtools tests are already unconditionally disabled (bug 1467313),
so there is no loss of coverage by removing the in-process test
scenario.

The other two tests already pass without disabling remote extensions.

This is the counterpart to test_verify_remote_mode.html

There will be a follow-up to remove support for the preference on desktop in bug 1613141.

See Also: → https://bugzilla.mozilla.org/show_bug.cgi?id=1613141
Pushed by rob@robwu.nl: https://hg.mozilla.org/integration/autoland/rev/82f81e2c5a27 Remove runtime changes to remote extension pref in mochitests r=mixedpuppy https://hg.mozilla.org/integration/autoland/rev/fd8ff6dd12db Test to verify that mochitests run with in-process extensions r=mixedpuppy https://hg.mozilla.org/integration/autoland/rev/266c3a19fac5 Read extensions.webextensions.remote once r=mixedpuppy

https://hg.mozilla.org/mozilla-central/rev/82f81e2c5a27
https://hg.mozilla.org/mozilla-central/rev/fd8ff6dd12db
https://hg.mozilla.org/mozilla-central/rev/266c3a19fac5

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox74: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla74

Hello,

Will this fix require manual validation? If yes, please provide some steps to reproduce in order to correctly test it and also, please set the "qe-verify+" flag. Otherwise, could the "qe-verify-" flag be added?

Thanks!

Flags: needinfo?(rob)

Covered by automated tests.

Flags: needinfo?(rob) → qe-verify-
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: