Closed Bug 1609474 Opened 5 years ago Closed 5 years ago

Reading extensions.webextensions.remote once for the purposes of Eval/Js Load Telemetry

Categories

(WebExtensions :: General, defect)

defect
Not set
normal

Tracking

(firefox73 fixed, firefox74 fixed)

RESOLVED FIXED
mozilla74
Tracking Status
firefox73 --- fixed
firefox74 --- fixed

People

(Reporter: tjr, Assigned: tjr)

References

Details

Attachments

(1 file)

This will avoid sending Telemetry if the pref is enabled during a session.

Attachment #9121096 - Attachment description: Bug 1609474 - Read extensions.webextensions.remote once for the purposes of Eval/JS Load Telemetry r?robwu → Bug 1609474 - Handle if extensions.webextensions.remote changes during runtime for the purposes of Eval/JS Load Telemetry r?robwu

Comment on attachment 9121096 [details]
Bug 1609474 - Handle if extensions.webextensions.remote changes during runtime for the purposes of Eval/JS Load Telemetry r?robwu

Beta/Release Uplift Approval Request

  • User impact if declined: We will delay collecting improving our Telemetry collection and will negatively impact a very small percentage of users who do weird non-default things such that their Firefox may behave in unexpected ways.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This is a small change that primarily affects an exception case for users who are doing non-standard things.
  • String changes made/needed:
Attachment #9121096 - Flags: approval-mozilla-beta?
Pushed by tritter@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4a5855f72ff4 Handle if extensions.webextensions.remote changes during runtime for the purposes of Eval/JS Load Telemetry r=robwu,ckerschb
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla74

Comment on attachment 9121096 [details]
Bug 1609474 - Handle if extensions.webextensions.remote changes during runtime for the purposes of Eval/JS Load Telemetry r?robwu

Telemetry improvement for some edge cases. Approved for 73.0b9.

Attachment #9121096 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Hello.
I see that that in the Beta/Release Uplift Approval Request it has been specified no manual testing is needed. If that is the case do you mind setting the "qe-verify" flag? If not, please provide more details/ steps to test the ticket.
Thank you

Flags: needinfo?(tom)
Flags: needinfo?(tom) → qe-verify-
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: