Closed Bug 1504713 Opened 6 years ago Closed 6 years ago

Invalid variable used in job icon tooltips

Categories

(Tree Management :: Treeherder: Frontend, defect, P1)

Product:
Tree Management
Component:
Treeherder: Frontend
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: emorley, Assigned: camd)

References

Details

Found by ESLint (no-restricted-globals). The `status` variable here is actually `window.status`, whereas I'm guessing it was meant to be one of `state`, `this.props.status` or something else? https://github.com/mozilla/treeherder/blob/bcf09f2cfa7d673f54b738eed4d1b11ba8918582/ui/job-view/pushes/JobButton.jsx#L81
From https://github.com/mozilla/treeherder/pull/4245#discussion_r231949032 : > I think we can take `- ${status}` out of the template here. > I can't think of what it was supposed to be at this point, > since resultStatus covers both result and state.

This will be fixed as part of:
https://github.com/mozilla/treeherder/pull/4513/files#diff-ab8a1ee0039542752136cabf8612f345L91

Assignee: nobody → cdawson
Status: NEW → ASSIGNED
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.