Open Bug 1504764 Opened 6 years ago Updated 2 years ago

Visiting yandex.ru multiple times creates a top site shortcut for yandex.com

Categories

(Firefox :: New Tab Page, enhancement, P5)

Product:
Firefox
Component:
New Tab Page
Type:
enhancement

Tracking

()

Iteration:
68.3 - Apr 15 - 28
Tracking Flags:
Tracking Status
firefox65 --- wontfix
firefox66 --- fix-optional

People

(Reporter: mkaply, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(1 obsolete file)

If you create a new profile and then visit yandex.ru and do some searches, when you restart you have a yandex alias. When you click on this alias, it goes to yandex.com, not yandex.ru. In addition, delete from history doesn't remove the alias because it's trying to remove yandex.com URLs, not yandex.ru URLs.
So the problem is here: https://searchfox.org/mozilla-central/source/toolkit/modules/NewTabUtils.jsm#1185 This code creates a shortURL for yandex.ru (yandex) and then passes it to getSearchProvider which returns yandex.com based on the list here: https://searchfox.org/mozilla-central/source/browser/components/newtab/lib/SearchShortcuts.jsm#14 We shouldn't be converting search URL domains to other search URL domains We should just be using the original domain and stripping off the rest of the URLs. There's no concept of a canonical URL - every search engine has a domain specific engine.
> every search engine has a domain specific engine. Should be: Most search engines have country specific engines.
Attached file Bug 1504764 - Use origin URLs for search tiles. (obsolete) (deleted) —
Assignee: nobody → mozilla
Iteration: --- → 65.2 (Nov 16)
Priority: -- → P2
Priority: P2 → P1
Iteration: 65.2 (Nov 16) → 65.3 (Nov 30)
Iteration: 65.3 (Nov 30) → 66.2 - Dec 24 - Jan 6
status-firefox65: affected → wontfix
status-firefox66: --- → fix-optional
Iteration: 66.2 - Dec 24 - Jan 6 → 66.3 - Jan 7 - 20
Iteration: 66.3 - Jan 7 - 20 → 67.1 - Jan 28 - Feb 10
Iteration: 67.1 - Jan 28 - Feb 10 → 67.3 - Feb 25 - Mar 10
Iteration: 67.3 - Feb 25 - Mar 10 → 67.4 - Mar 11 - 17
Blocks: 1479806
Iteration: 67.4 - Mar 11 - 17 → 68.1 - Mar 18 - 31
Iteration: 68.1 - Mar 18 - 31 → 68.2 - Apr 1 - 14

This patch is simply waiting for review from Mardak and is ready to go in.

Status: NEW → ASSIGNED
Depends on: 1480888
Iteration: 68.2 - Apr 1 - 14 → 68.3 - Apr 15 - 28

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:mkaply, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(mozilla)
Component: Activity Streams: Newtab → New Tab Page
Attachment #9023085 - Attachment description: Bug 1504764 - Use origin URLs for search tiles → Bug 1504764 - Use origin URLs for search tiles.

I'm doing a try build and I'll get this checked in.

Honestly, I didn't have enough confidence in my skills on this 2 years. I have more now.

This is the right fix for now and we have other bugs to fix this completely with search.

Flags: needinfo?(mozilla)
Priority: P1 → P5

I'm just going to give this one back. We've really had no reports of this and we should probably revisit at some point.

Assignee: mozilla → nobody
Status: ASSIGNED → NEW
Attachment #9023085 - Attachment is obsolete: true
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: