Closed
Bug 1505972
Opened 6 years ago
Closed 6 years ago
MDSM fails to seamless looping if media sink has been completed before MDSM enable looping
Categories
(Core :: Audio/Video: Playback, enhancement, P3)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla65
| Tracking | Status | |
|---|---|---|
| firefox65 | --- | fixed |
People
(Reporter: alwu, Assigned: alwu)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
text/x-phabricator-request
|
Details |
If media sink has been completed before we enable looping for MSDN, MDSM will fail to seamless looping.
The reason is that the state will be changed to `CompletedState` immediately after entering `LoopingDecodingState` [1], so we need to reopen sink again.
[1] https://searchfox.org/mozilla-central/rev/17f55aee76b7c4610a974cffd3453454e0c8de7b/dom/media/MediaDecoderStateMachine.cpp#2498
|
Assignee | |
Comment 1•6 years ago
|
||
When state changes to 'LoopingDecodingState', we need to make sure the media sink is still working.
Therefore, we have to reopen media sink if it has already been completed.
|
||
Comment 2•6 years ago
|
||
Marking P2 for now due to active work, awaiting priority on bug 1498733.
Rank: 19
Priority: -- → P2
|
|
Assignee | |
Updated•6 years ago
|
Priority: P2 → P3
|
|
Assignee | |
Comment 3•6 years ago
|
||
When entering 'loopingDecoding' state, we should ensure we would continue to decoding even if
the audio decoding has finished before.
|
||
Updated•6 years ago
|
Attachment #9023826 -
Attachment is obsolete: true
Pushed by alwu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a773a42f4c00
request audio data when entering 'loopingDecoding' state if decoding has ended r=jya
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
|
|
Assignee | |
Updated•6 years ago
|
Blocks: seamless-looping
No longer depends on: seamless-looping
You need to log in
before you can comment on or make changes to this bug.
Description
•