Closed
Bug 1506805
Opened 6 years ago
Closed 6 years ago
Upgrade to modern Font Awesome and use only the React version
Categories
(Tree Management :: Treeherder: Frontend, enhancement, P3)
Tree Management
Treeherder: Frontend
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: emorley, Assigned: emorley)
References
Details
Attachments
(2 files)
We're currently using Font Awesome v4 (https://fontawesome.com/v4.7.0/), which is only available as a fonts + CSS distribution.
We only use a few of the icons, yet the fonts+CSS implementation means having to download all of them regardless (the fonts vary between 77KB and 444KB depending on file type used by that browser, and the CSS is 37KB).
Font Awesome 5 has been out for a while now, and offers a superior SVG + JS solution that supports tree shaking. (The reason we haven't had a Renovate bot PR for the upgrade is that they've changed the package name for the new version.)
In addition, we currently use a mixture of plain Font Awesome and react-fontawesome, and so to simplify things we should consolidate on the latter rather than having the bundle-size and "things to learn" overhead of using both.
See:
https://fontawesome.com/how-to-use/on-the-web/setup/upgrading-from-version-4
https://fontawesome.com/how-to-use/on-the-web/using-with/react
Comment 1•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Priority: P2 → P3
Assignee | ||
Updated•6 years ago
|
No longer blocks: treeherder-react
Assignee | ||
Comment 2•6 years ago
|
||
First part landed in:
https://github.com/mozilla/treeherder/commit/f0abef42c0c17830c060b515831147bd6bd3206b
That leaves:
- job-view
- userguide
- (as part of the general react migration) Perfherder moving from stock Font Awesome v5 to react-fontawesome
Comment 3•6 years ago
|
||
Assignee | ||
Comment 4•6 years ago
|
||
I had the second part locally already from before and thought it was going to be a bit of work to finish it up, however it was pretty quick, so I decided to open a PR rather than just push it as a WIP branch :-)
Assignee: nobody → emorley
Status: NEW → ASSIGNED
Assignee | ||
Comment 5•6 years ago
|
||
https://github.com/mozilla/treeherder/commit/8aa5d30cad5266e0964a4b072091b7afd6ce1e9c
Closing this out for now since the Perfherder parts will be rewritten to use react-fontawesome as part of the React rewrite.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•