Closed
Bug 150749
(ToolbarBlanksPage)
Opened 22 years ago
Closed 22 years ago
Collapsing Personal Toolbar Loads Bogus http://personaltoolbar/ URL
Categories
(SeaMonkey :: Bookmarks & History, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: mrtech, Assigned: p_ch)
References
Details
(Keywords: dataloss, regression)
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
timeless
:
review+
|
Details | Diff | Splinter Review |
I had tried this in the past as a real test and the personal toolbar worked fine
and just happend to hit it by mistake with 6-10/8 build today.
If you collapse the toolbar the doc location changes and loads:
http://personaltoolbar/ and gives me a dns firewall error.
I thought it might be the Pinball theme, so I switch to Classic, complete shut
down and was reproducable.
Expected: Personal Toolbar collapse, nothing else happens
Actual: Personal Toolbar collapse, loads http://personaltoolbar/ url
Assignee | ||
Comment 1•22 years ago
|
||
confirming and taking this is a regression from my patch in bug 139471.
Assignee: ben → pierrechanial
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee | ||
Comment 2•22 years ago
|
||
*** Bug 150094 has been marked as a duplicate of this bug. ***
Assignee | ||
Comment 3•22 years ago
|
||
*** Bug 150839 has been marked as a duplicate of this bug. ***
Assignee | ||
Comment 4•22 years ago
|
||
I could not attach the patch yesterday due to the bmo upgrade. Patch is
straightforward.
All the event handlers were put in the personal <toolbar>. With this scheme,
events from the bookmarks button and the innermostBox <hbox> correctly bubble
to it.
Unfortunately, due to this bug, it is not possible to have this simple scheme.
Therefore, I copied the event handlers in both the bookmarks button and the
innermostBox hbox.
This new scheme may make Netscape life easier: events bubbling from widgets
added to the personal toolbar won't be handled anymore by the personal
<toolbar>
Assignee | ||
Comment 5•22 years ago
|
||
also fixes the issue reported in bug 150662 by preventing drag from
innermostBox
Attachment #87292 -
Attachment is obsolete: true
Comment 7•22 years ago
|
||
*** Bug 153323 has been marked as a duplicate of this bug. ***
Comment 8•22 years ago
|
||
*** Bug 153661 has been marked as a duplicate of this bug. ***
Comment 9•22 years ago
|
||
*** Bug 153725 has been marked as a duplicate of this bug. ***
Reporter | ||
Comment 10•22 years ago
|
||
Any update on this bug, it's still happening with the 062508 build, thanks.
Attachment #87296 -
Flags: review+
Comment 11•22 years ago
|
||
Just saw this bug with the modern theme on windows 2k build 150749
Comment 12•22 years ago
|
||
This bug also causes the session history to break on windows. A simimlar lost
session history happens when you drag and drop items on the personal toolbar.
Pierre, does your patch address these problems?
Blocks: 1.1b
Comment 13•22 years ago
|
||
*** Bug 157322 has been marked as a duplicate of this bug. ***
Comment 14•22 years ago
|
||
Hmm, collapsing any toolbar kills session history. This is not just personal
toolbar. This is nasty.
Severity: normal → major
Comment 15•22 years ago
|
||
*** Bug 158116 has been marked as a duplicate of this bug. ***
Updated•22 years ago
|
Keywords: dataloss,
regression
Comment 16•22 years ago
|
||
@14
Yeah... to be honest, I'd known about it for a few weeks before I reported it,
but have been really caught up with work. Last weekend was the only proper time
I had to myself... so I thought I'd mention it.
It would be so bad it if didn't kill the history as I reported in my bug report.
BTW, I searched for dupes before posting it, but couldn't find anything... Sorry.
Thanks.
Comment 17•22 years ago
|
||
The problem doesn't happen until I uncollapse the toolbar. When I uncollapse the
toolbar it loads a blank page (in all my tabs) and destroys my session history.
I see this error in the JS console when I uncollapse my toolbar
Error: getWebNavigation().currentURI has no properties
Source File: chrome://navigator/content/navigator.js
Line: 198
Comment 18•22 years ago
|
||
Just a note (from bug 157322):
I don't see a JS error when uncollapsing the toolbar, but instead when I
click on the forward or back button after the session history is destroyed:
Error: uncaught exception:
[Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE)
[nsIWebNavigation.sessionHistory]" nsresult: "0x80004005 (NS_ERROR_FAILURE)"
location: "JS frame :: chrome://navigator/content/sessionHistoryUI.js ::
FillHistoryMenu :: line 54" data: no]
Comment 19•22 years ago
|
||
Radha, can you please take a look at this. I suspect that it belongs to the
xpapps folks but it is wiping out history so perhaps you can help.
Comment 20•22 years ago
|
||
For me, the loading of the blank page does'nt occur until I move the mouse.
So long as I don't move the cursor or hit a key, it is fine.
Comment 21•22 years ago
|
||
*** Bug 158321 has been marked as a duplicate of this bug. ***
Comment 22•22 years ago
|
||
I believe that this problem is the result of the crash fix at bug 156719. I'm
not sure which is worse (I guess the crash was worse) but neither the crash nor
this bustage can be released as 1.1. dbaron has an additional patch related to
the fix for 156719 in bug 156971. I don't know if that would help this situation.
Comment 23•22 years ago
|
||
I just got the latest nightly (2002071911) and it appears to be fixed. I was
able to reproduce it in 1.1a but not the nightly. I am using WinXP.
Comment 24•22 years ago
|
||
I realize that I've morphed an older bug into a problem that only showed up on
7/12. I'll do what I can to fix that as soon as I do some further testing of the
newer problem. This bug will shortly return to it's original problem
"uncollapsing the personal toolbar attempts to load "personaltoolbar" as a URL.
The new problem is that uncollapsing any toolbar loads a blank page, disables
session history and makes visited links show up as unvisited (can't read from
global history?).
Comment 25•22 years ago
|
||
OK. My findings were confirmed. The problem with collapsing a toolbar causing a
blank page to be loaded and history to be broken is the result of checkins
related to bug 156719 (which was caused by the fix to bug 143862 ) and is not
related to this bug. The new problem, however, does seem to mask this problem.
Sorry for all the spam in this bug. I've reopened the incorrect dupes and the
new problem is now described at bug 157322
No longer blocks: 1.1b
Comment 26•22 years ago
|
||
*** Bug 158483 has been marked as a duplicate of this bug. ***
Comment 27•22 years ago
|
||
Grrr, so where should all these "Collapsing a toolbar makes page blank" bugs go?
I'm confused. Bug 157322 doesn't look like the proper one. Please find a proper
one then, relink appropriate dupes, and move the alias "ToolbarBlanksPage" to it.
Thanks.
Comment 28•22 years ago
|
||
*** Bug 158938 has been marked as a duplicate of this bug. ***
Assignee | ||
Comment 29•22 years ago
|
||
I forgot to mark this bug as fixed (by the patch in bug 128629) Sorry for that.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Comment 30•22 years ago
|
||
*** Bug 159705 has been marked as a duplicate of this bug. ***
Comment 31•22 years ago
|
||
*** Bug 161217 has been marked as a duplicate of this bug. ***
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•