- UnicodeNonBMP.h and friends should be added to .clang-format-ignore list - Generated FOR_EACH_NON_BMP_LOWERCASE, etc should use |MACRO| instead of |macro| - make_unicode.py should eventually be updated to better match style

Here are the files we will need to ignore (just the .h and .cpp files): https://searchfox.org/mozilla-central/search?q=generated+by+make_unicode.py&case=false&regexp=false&path=

Also there's a bunch of clang-format annotations in util/Unicode.cpp that should be moved into make_unicode.py or they'll be reverted next time we run the script: https://searchfox.org/mozilla-central/rev/5117a4c4e29fcf80a627fecf899a62f117368abf/js/src/util/Unicode.cpp#58

* Add generated files to .clang-format-ignore. * Remove the "clang-format off/on" annotations from generated files. * Rename FOR_EACH_NON_BMP_CASE_FOLDING argument from macro to MACRO. See bug 1508180.

Pushed by jdemooij@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ab5ae5f1e381 Some clang-format fixes for generated unicode files. r=tcampbell,sylvestre

[ESR Uplift Approval Request] If this is not a sec:{high,crit} bug, please state case for ESR consideration: This is required for easier backporting of patches after the reformatting of ESR using clang-format. User impact if declined: Declining this will negatively impact our developers' ability to easily backport their patches to ESR in the future. Fix Landed on Version: 65 Risk to taking this patch: Low Why is the change risky/not risky? (and alternatives if risky): Comment additions only, should not change anything in the binary. Has also been tested in Nightly for a while now. String or UUID changes made by this patch: None

Comment on attachment 9030811 [details] [diff] [review] ESR patch OK for uplift to ESR60 as part of the clang-format project.