Closed
Bug 1509258
Opened 6 years ago
Closed 6 years ago
GV API for "Is page reader viewable?" callback
Categories
(GeckoView :: General, enhancement, P1)
Tracking
(firefox-esr60 wontfix, firefox65 wontfix, firefox66 wontfix, firefox67 affected)
People
(Reporter: sebastian, Assigned: mbrubeck)
References
()
Details
(Whiteboard: [geckoview:fenix:m2])
Follow-up for bug 1509257: If GeckoView would actually provide a "Reader View" API then we would like to be able to show a "Reader View" button in the UI *before* switching to "Reader View". For that we would need some kind of callback that tells us whether the current page can be shown in "Reader View".
|
Reporter | |
Updated•6 years ago
|
|
||
Updated•6 years ago
|
Points: --- → 13
Whiteboard: [geckoview:fenix:p1]
|
|
||
Comment 1•6 years ago
|
||
Fenix team says this is a P2 for Fenix MVP.
Whiteboard: [geckoview:fenix:p1] → [geckoview:fenix:p2]
|
||
Updated•6 years ago
|
Product: Firefox for Android → GeckoView
|
||
Updated•6 years ago
|
Priority: -- → P3
|
|
||
Comment 2•6 years ago
|
||
Adding [geckoview:fenix:m3] because the Fenix team wants Reader View in Fenix M3:
https://github.com/mozilla-mobile/android-components/issues/2005
We might not need this "is page reader viewable?" GV API if Reader View is handled entirely in A-C (as suggested in bug 1509257).
status-firefox65:
--- → wontfix
status-firefox66:
--- → wontfix
status-firefox67:
--- → fix-optional
status-firefox-esr60:
--- → wontfix
Whiteboard: [geckoview:fenix:p2] → [geckoview:fenix:p2] [geckoview:fenix:m3]
|
|
||
Comment 3•6 years ago
|
||
Removing [geckoview:fenix:p2] because this bug can't be "P2 nice-to-have" for Fenix MVP if it is also [geckoview:fenix:m3] needed for Fenix's M3 milestone.
OS: Unspecified → Android
Priority: P3 → P1
Summary: GeckoView: Is page "reader viewable" callback → GV API for "Is page reader viewable?" callback
Whiteboard: [geckoview:fenix:p2] [geckoview:fenix:m3] → [geckoview:fenix:m3]
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → mbrubeck
|
|
||
Comment 4•6 years ago
|
||
Fenix wants to implement Reader View in Fenix M3, so A-C and GV should provide support in M2.
Whiteboard: [geckoview:fenix:m3] → [geckoview:fenix:m2]
|
|
||
Comment 5•6 years ago
|
||
Matt says we can close this bug. We don't need to add a new GV API because the Reader View extension will be able to communicate the page readability using WebExtension messaging (bug 1518843) or PageActions (bug 1530402).
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INVALID
You need to log in
before you can comment on or make changes to this bug.
Description
•