I identified the following missing default values for the FxA signup template in ASR snippets: - scene1_button_label has no default value. `Learn more` - scene2_placeholder_text has no default `YOUR EMAIL HERE` - scene2_dismiss_button has no default `Dismiss` - scene2_button_label has no default `Sign Me Up` Tested on 65.0a1. Also please make sure to uplift those issues currently fixed in nightly to beta: - scene2_text is not rich text - fixed in nightly - scene2_title will not appear - fixed in nightly - scene2_text is larger compared to scene1_text (14px vs 12px) - fixed in nightly I'm available to help interpret current templates and answer any questions if needed. See also https://github.com/mozmeao/snippets-service/issues/833

Can you please confirm that * scene2_placeholder_text is scene2_email_placeholder_text * scene2_dismiss_button is scene2_dismiss_button_text From: https://github.com/mozmeao/snippets/blob/master/activity-stream/fxa.html#L254-L257 Looks like scene2_dismiss_button_text is indeed missing.

(In reply to Andrei Oprea [:andreio] from comment #1) > Can you please confirm that > * scene2_placeholder_text is scene2_email_placeholder_text > * scene2_dismiss_button is scene2_dismiss_button_text > From: > https://github.com/mozmeao/snippets/blob/master/activity-stream/fxa. > html#L254-L257 > > Looks like scene2_dismiss_button_text is indeed missing. Correct. Thank you

Commit pushed to master at https://github.com/mozilla/activity-stream https://github.com/mozilla/activity-stream/commit/3803f348fc3a9a86bd8716a3505a36b46b3705e2 Fix Bug 1509810 - Add missing defaults for snippet templates (#4579)

[Tracking Requested - why for this release]: These changes are needed in order for us to ship the FXA snippets template as well as properly handle metrics information in URLs

Comment on attachment 9028708 [details] Bug 1509810 - ASR Snippets: FxA signup template issues [Beta/Release Uplift Approval Request] Feature/Bug causing the regression: Bug 1492085 User impact if declined: Snippets for Firefox accounts campaigns will be missing default values and will impact the effectiveness/cause noticeable visual bugs. Is this code covered by automated tests?: Yes Has the fix been verified in Nightly?: Yes Needs manual test from QE?: Yes If yes, steps to reproduce: Please verify with steps in FXA section of doc: https://docs.google.com/document/d/1U8QegwAIXcm3pkznL0mvZ2r0tNXSsnbu9rH82c2dNyQ/edit#heading=h.8aojoumhto2a List of other uplifts needed: None Risk to taking this patch: Low Why is the change risky/not risky? (and alternatives if risky): Changes to default values, behind the snippets roll-out pref String changes made/needed:

Comment on attachment 9028708 [details] Bug 1509810 - ASR Snippets: FxA signup template issues AS snippets fix, approved for 64.0 rc1

https://hg.mozilla.org/releases/mozilla-release/rev/f4770816becd https://hg.mozilla.org/releases/mozilla-beta/rev/41d8ca0ac75604ed9d409d58e2eae2a7786ef516 (FIREFOX_64b_RELBRANCH)

I have verified this issue with the latest "Firefox Beta" build (64.0 Build ID - 20181205213546) and with the latest "Firefox Nightly" build (65.0a1 Build ID - 20181206214149) installed, on Windows 10 x64, Arch Linux 4.16.6 x64 and Mac 10.13.3, and I can confirm the following: Stage 1 part: - An icon displayed in the left part of the snippet; - The body text of the snippet is displayed in the right part of the icon; - A button with the specific text label is displayed in the right part of the body text; - The "X" button is displayed in the right part of the snippet at hover. Stage 2 part: - The body text is displayed on the top-middle part of the snippet; - A text field containing a placeholder text message is displayed under the body text; - A button, with a specific text label, is displayed in the right part of the text field; - The "Dismiss" button is displayed in the bottom part of the snippet.