Closed Bug 1509851 Opened 6 years ago Closed 6 years ago

ASR Snippets: EOY (fundraising) template issues

Categories

(Firefox :: New Tab Page, enhancement, P1)

enhancement

Tracking

()

VERIFIED FIXED
Firefox 65
Iteration:
65.3 - Nov 30
Tracking Status
firefox64 --- verified
firefox65 --- verified

People

(Reporter: giorgos, Assigned: andreio)

References

Details

Attachments

(1 file)

I identified the following missing default values for the Fundraising (EOY) template in ASR snippets: - We always display icon (defaults to Fx logo) - monthly_checkbox_label_text has no default. Should be Make my donation monthly - selected_button no default value. Should be donation_amount_second - currency_code no default value. Should be usd - donation_form_url URL params do not get preserved. Example value for this field `https://donate.mozilla.org/pl/utm_source=desktop-snippet&utm_medium=snippet&utm_campaign=donate&utm_term=7556` Tested on 65.0a1. I'm available to help interpret current templates and answer any questions if needed. See also https://github.com/mozmeao/snippets-service/issues/834
Attached image checkbox (deleted) —
Also checkbox doesn't look nice
Assignee: nobody → andrei.br92
Iteration: --- → 65.3 (Nov 30)
Priority: -- → P1
This was fixed and landed in bug 1510766. This fix is in beta 64.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Blocks: 1510766
I have verified this issue with the latest "Firefox Beta" build (64.0 Build ID - 20181205213546) and with the latest "Firefox Nightly" build (65.0a1 Build ID - 20181206214149) installed, on Windows 10 x64, Arch Linux 4.16.6 x64 and Mac 10.13.3, and I can confirm the following: - An icon displayed in the left part of the snippet; - The body text of the snippet is displayed in the right part of the icon; - Four buttons each with a different donations amount are displayed in the left part of the snippet, under the body text. (Values by default in USD); - A checkbox followed by the "Make my donation monthly" string is displayed in the right part of the donation buttons; - A button with a specific text label is displayed in the right part of the snippet, under the body text; - The "X" button is displayed in the right part of the snippet at hover.
Status: RESOLVED → VERIFIED
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: