https://searchfox.org/mozilla-central/source/testing/raptor/raptor/playback/alternate-server-replay.py#154 We generate the best match for the current request and return the last request in the list (candidate_flow) Because of this we don't send the correct response and the site is not loading properly.

Mitmproxy alternate-server-replay returns last found request ignoring match algorithm

Originally the alternate-server-replay script was developed by dev (:bsmedberg, no longer at Moz). I don't feel qualified to review any changes to this script; I prefer someone in development have a look. :acreskey, would you be able to review this change? I would prefer dev approve any changes to this. Thanks! :)

try build to see the impact of this change: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c8818c9b967dbb58d87ac02a7a090e981b8f316b

:Bebe That looks like a good find (the algorithm returning the last item regardless of the match). Can you tell me the scenario where this was failing? i.e. which test?

the best example of this is when trying to record wikipedia with the current code when doing replay we see a strange looking page without any css When updating the code and returning the correct find of the candidate_flow we get the normal wiki page. To replay I used: mitmdump -k -s "alternate-server-replay-2.0.2.py wiki.mp" Find the recording attached

This is the wiki recording used to test.

:Bebe Good stuff, thanks. Do you think this is related to the following issue? https://bugzilla.mozilla.org/show_bug.cgi?id=1509835 I did try your patch but it didn't fix it for me.

:Andrew is there anything else here? I found that this is blocking some other recordings

:bebe I'm good with the change, but I was of the understanding that it was breaking other sites?

I created a try push contining this bug and the screenshots bug to see if there are any issues with the change https://treeherder.mozilla.org/#/jobs?repo=try&revision=ab08ca8f43f1a67cac5f1fe638db027cede97b08

From what I see all the tests work fine :Andrew :rwood :davehunt wohat would be the next step for this?

I am fine with landing this as long as :acreskey and :davehunt are, and as long as you (:bebe) have verified that all the pages are still loading correctly on all the platforms on both Firefox and Chromium. Please rebase to the latest, and push to try again and also include the tp6 jobs on Chromium. Then I'd suggest putting the patch up for formal r? by acreskey. Thanks :bebe!

Good with the change as well -- it makes sense.

Pushed by fstrugariu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d73d20bd962a Mitmproxy alternate-server-replay returns last found request ignoring match algorithm r=acreskey