Closed
Bug 1511341
Opened 6 years ago
Closed 5 years ago
Add Nextflix to tp6
Categories
(Testing :: Raptor, enhancement, P2)
Tracking
(firefox69 fixed)
RESOLVED
FIXED
mozilla69
Tracking | Status | |
---|---|---|
firefox69 | --- | fixed |
People
(Reporter: davehunt, Assigned: Bebe)
References
Details
Attachments
(3 files, 1 obsolete file)
This tracks adding Netflix to tp6.
URL: https://www.netflix.com/watch/70279201
Hero: Play button
Account: See FxPerfTest vault in 1password
Profile: Use the FxPerfTest profile in Netflix
Reporter | ||
Comment 1•6 years ago
|
||
:vchin please could or someone from your team confirm that you're happy with the URL and hero element?
Flags: needinfo?(vchin)
Comment 2•6 years ago
|
||
I would suggest we add Netflix to the existing tp6-6 suite, as that job only has the one page so far (reddit) and a short run time (7-11 min).
Comment 3•6 years ago
|
||
Play button looks good.
How do we currently handle the auto play doorhanger in tests?
Flags: needinfo?(vchin)
Comment 4•6 years ago
|
||
I should clarify play button as the hero element is ok. URL is ok as well.
Reporter | ||
Comment 5•6 years ago
|
||
(In reply to Vicky Chin [:vchin] from comment #3)
> Play button looks good.
> How do we currently handle the auto play doorhanger in tests?
If we don't already, then we should probably handle this by setting a preference. It looks like the following should work:
name: media.autoplay.default
value: 1
0 = allowed
1 = blocked
2 = prompt (default)
Assignee | ||
Comment 6•6 years ago
|
||
(In reply to Robert Wood [:rwood] from comment #2)
> I would suggest we add Netflix to the existing tp6-6 suite, as that job only
> has the one page so far (reddit) and a short run time (7-11 min).
how wold we handle updating the zip file? Can it be overwritten?
Assignee | ||
Comment 7•6 years ago
|
||
Assignee | ||
Comment 8•6 years ago
|
||
and recording file:
https://drive.google.com/open?id=1RmMjIw1uEXXHB6BcirfflD_ANCXgIsJ6
Assignee | ||
Comment 9•6 years ago
|
||
We have a banner with the enable DRM notice when we run the test.
Would that affect the results?
Reporter | ||
Updated•6 years ago
|
Assignee: nobody → fstrugariu
Status: NEW → ASSIGNED
Reporter | ||
Comment 10•6 years ago
|
||
(In reply to Florin Strugariu [:Bebe] from comment #9)
> Created attachment 9030405 [details]
> netflix.png
>
> We have a banner with the enable DRM notice when we run the test.
> Would that affect the results?
I think we should enable DRM for this test, but it's likely that this differs depending on the platform. For example on macOS I get a banner saying "Firefox is installing components needed to play the audio or video on this page. Please try again later".
You may have some luck setting media.gmp-widevinecdm.visible and media.gmp-widevinecdm.enabled preferences to true. https://searchfox.org/mozilla-central/source/dom/media/eme/MediaKeySystemAccess.cpp#127
Your screenshot also shows a "Netflix site error" message, which we should look into if it's unrelated to the DRM playback.
Assignee | ||
Comment 11•6 years ago
|
||
:rwood can we activate the DRM in our raptor profile?
Flags: needinfo?(rwood)
Comment 12•6 years ago
|
||
(In reply to Florin Strugariu [:Bebe] from comment #11)
> :rwood can we activate the DRM in our raptor profile?
If there are prefs required for specific Raptor tests, you can just add a 'preferences' item in the test INI, i.e.:
https://searchfox.org/mozilla-central/rev/3160ddc1f0ab55d230c595366662c62950e5c785/testing/raptor/raptor/tests/raptor-wasm-godot-ion.ini#21
Flags: needinfo?(rwood)
Assignee | ||
Comment 13•6 years ago
|
||
Investigated this:
1. DRM popup can be fixed by adding "media.eme.enabled":true
2. Netflix error it's because of bug 1511029
Depends on: 1511029
Reporter | ||
Updated•6 years ago
|
Priority: -- → P1
Assignee | ||
Comment 14•6 years ago
|
||
Updated.
Tested this on firefox and works fine
On chrome I get a mithmprxy crash.
:rwood can you run a test on chrome plase
Flags: needinfo?(rwood)
Comment 15•6 years ago
|
||
I haven't tried this yet, but if mitmproxy is crashing when running this with Chrome on your platform then it can't be landed. Suggest upgrading Chrome, or maybe try re-recording the page.
Flags: needinfo?(rwood)
Assignee | ||
Comment 16•6 years ago
|
||
Tried to find a solution to this all day but failed.
My suggestion here is to have only the firefox working tests.
Assignee | ||
Comment 17•6 years ago
|
||
To have more context on what's happening in Chrome
One request to https://push.prod.netflix.com/ws causes a internal mitmproxy error.
From my finding this is chrome specific.
```
For request https://push.prod.netflix.com/ws found exact replay match
127.0.0.1:43190: GET https://push.prod.netflix.com/ws
[replay] << 101 Switching Protocols 0b
WebSocket connection closed by client: (status code missing) (message missing), unknown status code
127.0.0.1:43190: clientdisconnect
127.0.0.1:43190: Traceback (most recent call last):
File "/home/florinstrugariu/mozilla/mitmprox/ven/lib/python3.6/site-packages/mitmproxy/proxy/server.py", line 119, in handle
root_layer()
File "/home/florinstrugariu/mozilla/mitmprox/ven/lib/python3.6/site-packages/mitmproxy/proxy/modes/http_proxy.py", line 9, in __call__
layer()
File "/home/florinstrugariu/mozilla/mitmprox/ven/lib/python3.6/site-packages/mitmproxy/proxy/protocol/tls.py", line 383, in __call__
layer()
File "/home/florinstrugariu/mozilla/mitmprox/ven/lib/python3.6/site-packages/mitmproxy/proxy/protocol/http1.py", line 72, in __call__
layer()
File "/home/florinstrugariu/mozilla/mitmprox/ven/lib/python3.6/site-packages/mitmproxy/proxy/protocol/http.py", line 188, in __call__
if not self._process_flow(flow):
File "/home/florinstrugariu/mozilla/mitmprox/ven/lib/python3.6/site-packages/mitmproxy/proxy/protocol/http.py", line 257, in _process_flow
return self.handle_regular_connect(f)
File "/home/florinstrugariu/mozilla/mitmprox/ven/lib/python3.6/site-packages/mitmproxy/proxy/protocol/http.py", line 206, in handle_regular_connect
layer()
File "/home/florinstrugariu/mozilla/mitmprox/ven/lib/python3.6/site-packages/mitmproxy/proxy/protocol/tls.py", line 383, in __call__
layer()
File "/home/florinstrugariu/mozilla/mitmprox/ven/lib/python3.6/site-packages/mitmproxy/proxy/protocol/http1.py", line 72, in __call__
layer()
File "/home/florinstrugariu/mozilla/mitmprox/ven/lib/python3.6/site-packages/mitmproxy/proxy/protocol/http.py", line 188, in __call__
if not self._process_flow(flow):
File "/home/florinstrugariu/mozilla/mitmprox/ven/lib/python3.6/site-packages/mitmproxy/proxy/protocol/http.py", line 420, in _process_flow
layer()
File "/home/florinstrugariu/mozilla/mitmprox/ven/lib/python3.6/site-packages/mitmproxy/proxy/protocol/websocket.py", line 154, in __call__
r = tcp.ssl_read_select(conns, 0.1)
File "/home/florinstrugariu/mozilla/mitmprox/ven/lib/python3.6/site-packages/mitmproxy/net/tcp.py", line 387, in ssl_read_select
] or select.select(rlist, (), (), timeout)[0]
TypeError: argument must be an int, or have a fileno() method.
```
Reporter | ||
Comment 18•6 years ago
|
||
:bebe if this can be replicated outside of Raptor, please open an issue against mitmproxy
Updated•5 years ago
|
Attachment #9030400 -
Attachment is obsolete: true
Assignee | ||
Comment 20•5 years ago
|
||
As we are planning a massive re record. let's include these tests in that process
Assignee | ||
Comment 21•5 years ago
|
||
Depends on D34327
Assignee | ||
Comment 22•5 years ago
|
||
Depends on D34329
Comment 23•5 years ago
|
||
Pushed by fstrugariu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6d6a2f0e6b0a
Fix Log message when replaing with no-upstream-cert in Raptor r=perftest-reviewers,AlexandruIonescu
https://hg.mozilla.org/integration/autoland/rev/201d8ae3dbd5
Add Nextflix to tp6 r=perftest-reviewers,igoldan,AlexandruIonescu
Comment 24•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/6d6a2f0e6b0a
https://hg.mozilla.org/mozilla-central/rev/201d8ae3dbd5
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox69:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in
before you can comment on or make changes to this bug.
Description
•