Closed
Bug 1512332
Opened 6 years ago
Closed 6 years ago
Update focus ring acording to photon specs
Categories
(Toolkit :: Themes, enhancement, P2)
Toolkit
Themes
Tracking
()
RESOLVED
FIXED
mozilla66
People
(Reporter: Matthias, Assigned: Matthias)
References
(Blocks 1 open bug, Regressed 1 open bug)
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
Everything (menulists etc) should have the blue focus shadow.
Updated•6 years ago
|
Priority: -- → P2
Assignee | ||
Comment 1•6 years ago
|
||
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f306a3db8b35
Photonized focusring for menulist etc. r=dao
Updated•6 years ago
|
Assignee: nobody → matthias
Comment 3•6 years ago
|
||
Backed out changeset f306a3db8b35 (Bug 1512332) for bc failures on chrome://global/skin/in-content/common.css.
Backout: https://hg.mozilla.org/integration/autoland/rev/25f55c5ebcfb1263b910551ac0f9599345c1b6f2
Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=success%2Cpending%2Crunning%2Ctestfailed%2Cbusted%2Cexception&revision=f306a3db8b35c5821cbfdebd85f83b7da91822c8&selectedJob=217261196
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=217261196&repo=autoland&lineNumber=1909
Flags: needinfo?(matthias)
Assignee | ||
Comment 4•6 years ago
|
||
I'm sorry, but I have no idea how to fix this error and why it occurs =/
@dao, can you help me?
Flags: needinfo?(matthias) → needinfo?(dao+bmo)
Comment 5•6 years ago
|
||
The error message is:
Expected identifier for pseudo-class parameter but found ‘:’. Ruleset ignored due to bad selector.
The problem appears to be the chained pseudo-element selectors that CSS doesn't seem to allow:
html|input[type="color"]::-moz-number-spin-up::-moz-focus-inner,
html|input[type="number"]::-moz-number-spin-down::-moz-focus-inner
(There's also another typo in there... "color" should be "number".)
Flags: needinfo?(dao+bmo)
Assignee | ||
Comment 6•6 years ago
|
||
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b02de5a5396b
Photonized focusring for menulist etc. r=dao
Comment 8•6 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
Updated•6 years ago
|
Updated•6 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•