Closed
Bug 1512489
Opened 6 years ago
Closed 6 years ago
Convert datetime-popup to a lazily loaded JSM
Categories
(Toolkit :: XUL Widgets, task, P3)
Toolkit
XUL Widgets
Tracking
()
RESOLVED
FIXED
mozilla66
| Tracking | Status | |
|---|---|---|
| firefox66 | --- | fixed |
People
(Reporter: timdream, Assigned: timdream)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
The only user of datetime-popup implementation is DateTimePickerParent.jsm -- change the caller there will allow us to convert it to another JSM or a custom element.
We couldn't simplify this by merging it to DateTimePickerParent.jsm [1]; it init()s in BrowserGlue._onFirstWindowLoaded().
[1] https://searchfox.org/mozilla-central/rev/adec563403271e78d1a057259b3e17fe557dfd91/browser/components/nsBrowserGlue.js#1355
|
Assignee | |
Comment 1•6 years ago
|
||
(In reply to Tim Guan-tin Chien [:timdream] (please needinfo) from comment #0)
> We couldn't simplify this by merging it to DateTimePickerParent.jsm [1]; it
> init()s in BrowserGlue._onFirstWindowLoaded().
Well, perhaps that's not really a problem given there are only a few hundred lines, not thousands.
|
||
Updated•6 years ago
|
Component: XBL → XUL Widgets
Product: Core → Toolkit
|
|
Assignee | |
Comment 3•6 years ago
|
||
|
|
Assignee | |
Updated•6 years ago
|
Summary: Convert datetime-popup to a lazily loaded custom element → Convert datetime-popup to a lazily loaded JSM
|
|
Assignee | |
Comment 4•6 years ago
|
||
|
||
Updated•6 years ago
|
Priority: -- → P3
Pushed by tchien@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c41d930784a8
Convert datetime-popup binding to a JSM r=Felipe
|
||
Comment 6•6 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
|
||
Updated•5 years ago
|
Type: enhancement → task
You need to log in
before you can comment on or make changes to this bug.
Description
•