<input type="date/time"> popup text is unreadable if dark mode is enabled
Categories
(Firefox :: Theme, defect, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr60 | --- | unaffected |
| firefox65 | --- | unaffected |
| firefox66 | + | fixed |
| firefox67 | --- | verified |
People
(Reporter: itiel_yn8, Assigned: timdream)
References
Details
(Keywords: regression)
Attachments
(3 files)
|
(deleted),
image/png
|
Details | |
|
(deleted),
image/png
|
Details | |
|
(deleted),
text/x-phabricator-request
|
lizzard
:
approval-mozilla-beta+
|
Details |
<input type="date">
See screenshots.
This is a regression from bug 1512489.
|
Assignee | |
Comment 2•6 years ago
|
||
Can't think of how this can break on top of my head ... thanks for filing.
(In reply to Tim Guan-tin Chien [:timdream] (please needinfo) from comment #2)
Can't think of how this can break on top of my head ... thanks for filing.
Forgot to add that prior to bug 1512489, these popups were not affected by the dark mode at all (their background was still white if dark mode was enabled).
|
|
Assignee | |
Comment 4•6 years ago
|
||
I removed the "active" attribute in bug 1512489 and didn't realize there is a selector in this sheet.
These CSS variables was added in bug 1317581 to reset background color of the picker.
|
||
Updated•6 years ago
|
|
||
Comment 7•6 years ago
|
||
| bugherder | ||
Fixed on latest Nightly.
Are there any plans on adding a dark flavor to the date/time picker? Should I file a bug?
|
|
Assignee | |
Comment 9•6 years ago
|
||
(In reply to Itiel from comment #8)
Are there any plans on adding a dark flavor to the date/time picker? Should I file a bug?
Please file a bug.
|
|
Assignee | |
Comment 10•6 years ago
|
||
Comment on attachment 9039376 [details]
Bug 1522779 - Correct datetime picker panel background color r=jaws
Beta/Release Uplift Approval Request
Feature/Bug causing the regression
User impact if declined
The background color of the date time picker will be incorrect.
Is this code covered by automated tests?
No
Has the fix been verified in Nightly?
Yes
Needs manual test from QE?
No
If yes, steps to reproduce
List of other uplifts needed
None
Risk to taking this patch
Low
Why is the change risky/not risky? (and alternatives if risky)
one line fix.
String changes made/needed
none
Comment on attachment 9039376 [details]
Bug 1522779 - Correct datetime picker panel background color r=jaws
Verified in Nightly, let's uplift to fix this new regression.
Should land for beta 4.
|
||
Comment 12•6 years ago
|
||
| bugherder uplift | ||
|
||
Updated•6 years ago
|
Description
•