Remove textbox binding
Categories
(Toolkit :: XUL Widgets, task)
Tracking
()
Tracking | Status | |
---|---|---|
firefox71 | --- | fixed |
People
(Reporter: ntim, Assigned: ntim)
References
(Blocks 4 open bugs)
Details
Attachments
(2 files, 1 obsolete file)
Assignee | ||
Comment 1•6 years ago
|
||
Updated•6 years ago
|
Assignee | ||
Updated•6 years ago
|
Comment hidden (obsolete) |
Assignee | ||
Comment 3•6 years ago
|
||
Shorter plan to remove all the textbox bindings requiring less effort:
- Fix bug 1521280
- Wait for quantumbar and remove legacy-urlbar
- Fix bug 1513337
- Fix bug 1534404
- Convert all <textbox> (except type="autocomplete") to <input>
- Convert autocomplete to CE
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Updated•6 years ago
|
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 4•5 years ago
|
||
Comment 5•5 years ago
|
||
Assignee | ||
Comment 6•5 years ago
|
||
Hi Emilio, panel/arrowpanel is getting removed in bug 1397876, which means textbox will be the last binding to be removed. 🎉
I was however wondering what to do with the ‘MayNeedToLoadXBLBinding’ function. Not sure how conservative we are at removing the XBL platform code (for the unlikely event that we want to restore an XBL binding), but the simplest option would be to replace the ‘if (!aElement.IsAnyOfXULElements(nsGkAtoms::textbox)) {‘ check with ‘if (true)’, but may as well remove all the related code in this case.
Would you be OK with removing MayNeedToLoadXBLBinding and the related code? If so, is this something you can provide a patch for?
Comment 7•5 years ago
|
||
(In reply to Tim Nguyen :ntim from comment #6)
Hi Emilio, panel/arrowpanel is getting removed in bug 1397876, which means textbox will be the last binding to be removed. 🎉
I was however wondering what to do with the ‘MayNeedToLoadXBLBinding’ function. Not sure how conservative we are at removing the XBL platform code (for the unlikely event that we want to restore an XBL binding), but the simplest option would be to replace the ‘if (!aElement.IsAnyOfXULElements(nsGkAtoms::textbox)) {‘ check with ‘if (true)’, but may as well remove all the related code in this case.
Would you be OK with removing MayNeedToLoadXBLBinding and the related code? If so, is this something you can provide a patch for?
If Emilio is fine with it, I'd prefer to make that function just return false in this patch, with a comment pointing to Bug 1585823 for removal. I suspect there's a bit of cleanup to follow on with and would rather do it in a separate bug.
Comment hidden (obsolete) |
Assignee | ||
Updated•5 years ago
|
Comment 9•5 years ago
|
||
Yeah, let's do that, or just not touch that function at all and I'll get rid of it in that bug.
Updated•5 years ago
|
Assignee | ||
Comment 10•5 years ago
|
||
Assignee | ||
Comment 11•5 years ago
|
||
Comment 12•5 years ago
|
||
Comment 13•5 years ago
|
||
There is one failure on Windows AArch left: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Csuperseded%2Cretry%2Cusercancel&searchStr=windows%2Caarch&revision=59f0469f5a486ddea7543100b3f335706b072955
Assignee | ||
Comment 14•5 years ago
|
||
Comment 15•5 years ago
|
||
Assignee | ||
Updated•5 years ago
|
Comment 16•5 years ago
|
||
bugherder |
Comment 17•5 years ago
|
||
bugherder |
Description
•