We forgot to catch these apparently: https://searchfox.org/mozilla-central/search?q=%3Cxul%3Atextbox&path= :)

Johann, is the old cert viewer something we're still shipping in 71 ?

Brian, do you think you could find someone to look at the tests ?

(In reply to Tim Nguyen :ntim from comment #0)

We forgot to catch these apparently: https://searchfox.org/mozilla-central/search?q=%3Cxul%3Atextbox&path= :)

Johann, is the old cert viewer something we're still shipping in 71 ?

Brian, do you think you could find someone to look at the tests ?

Yes, unfortunately. It's fully behind a pref but we don't want to remove the code in 71 yet. However, it's very unlikely to be used, so we can probably go with the cheapest solution that works.

Thanks Johann! I'll take this one then.

I actually intentionally marked this as defect as it totally breaks the old cert viewer.

https://hg.mozilla.org/mozilla-central/rev/f748a3d2cdf1

Comment on attachment 9103254 [details]
Bug 1590387 - Remove remaining usages of XUL textboxes. r=bgrins

Beta/Release Uplift Approval Request

• User impact if declined: Old certificate Viewer (enabled by default on 71) is broken.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Open cert viewer, see attachment 9103410 [details]
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Trivial XUL+CSS change that was manually tested.
• String changes made/needed: no

Let's have it in Nightly and verified by QA before uplifting.

Here are some more precise verification steps for Nightly:

• Set security.aboutcertificate.enabled to false
• Go to https://www.mozilla.org/en-US/
• Right click and click "View Page Info"
• Go to the "Security" tab
• Click "View Certificate"
• See the broken cert viewer

Comment on attachment 9103254 [details]
Bug 1590387 - Remove remaining usages of XUL textboxes. r=bgrins

Fix for certificate viewer broken in 71, uplift approved for 71 beta 4, let's have QA verify the fix on beta.

https://hg.mozilla.org/releases/mozilla-beta/rev/d5a8eb9b5da9

Hello! Reproduced the issue using STR from comment 11 with Firefox 72.0a1 (20191022214314) on Windows 10x64.
The issue is verified fixed using Firefox 72.0a1 (20191023215406) and 71.0b4 (20191024095932) from comment 13 on Windows 10x64, macOS 10.14 and Ubuntu 18.04. The "Certificate Viewer" is correctly shown.