Closed
Bug 1513486
Opened 6 years ago
Closed 6 years ago
Remove gzipped runnable jobs support once enough time has passed since bug 1423215
Categories
(Tree Management :: Treeherder, enhancement, P2)
Tree Management
Treeherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: emorley, Assigned: emorley)
References
Details
Attachments
(1 file)
(deleted),
text/x-github-pull-request
|
Details |
Bug 1423215 made tasks upload both the old and new style runnable jobs file, then bug 1494750 added Treeherder support for the new style file.
Once enough time has passed (eg so that the majority of try pushes have a base that includes the changes in bug 1423215), support for the old style file can be removed from Treeherder.
The old file handling parts that can be cleaned up are here:
https://github.com/mozilla/treeherder/blob/e69b3f01804de91028cbe7b4e263f4977ff45699/ui/models/runnableJob.js#L16-L25
https://github.com/mozilla/treeherder/blob/e69b3f01804de91028cbe7b4e263f4977ff45699/treeherder/etl/runnable_jobs.py#L37-L47
https://github.com/mozilla/treeherder/blob/e69b3f01804de91028cbe7b4e263f4977ff45699/treeherder/etl/runnable_jobs.py#L67-L79
In addition:
* fetch_json()'s support for `force_gzip_decompression` can be removed (https://github.com/mozilla/treeherder/blob/e69b3f01804de91028cbe7b4e263f4977ff45699/treeherder/etl/common.py#L35-L43)
* the runnable jobs API can be removed:
- https://github.com/mozilla/treeherder/blob/e69b3f01804de91028cbe7b4e263f4977ff45699/treeherder/webapp/api/runnable_jobs.py
- https://github.com/mozilla/treeherder/blob/e69b3f01804de91028cbe7b4e263f4977ff45699/treeherder/webapp/api/urls.py#L31-L35
* Several parts of runnable_jobs.py and SETA can be simplified, since they will only ever be fetching the most recent task ID
Assignee | ||
Comment 1•6 years ago
|
||
Stats for the fallback use can be seen here:
https://insights.newrelic.com/accounts/677903/explorer/events?eventType=runnable_jobs_fallback&duration=604800000
Comment 2•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → emorley
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•6 years ago
|
||
https://github.com/mozilla/treeherder/commit/a9aa1d5a2742d564789f92885cdefa1623a810e8
https://github.com/mozilla/treeherder/commit/6483b387c8de6712ca2175a53588a27ef4035cec
https://github.com/mozilla/treeherder/commit/fd0ceb960ffbea57a50b6af9a193df4257471fdb
https://github.com/mozilla/treeherder/commit/9c3985a2e7661793b0e457228c03627b3129b9e3
https://github.com/mozilla/treeherder/commit/35c9fd9fd807fd18a3c3ca74ea973aa1a3996108
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Updated•3 years ago
|
Component: Treeherder: Job Triggering & Cancellation → TreeHerder
You need to log in
before you can comment on or make changes to this bug.
Description
•