Closed
Bug 1514022
Opened 6 years ago
Closed 6 years ago
Create a card section component for Activity Stream experiment functionality
Categories
(Firefox :: New Tab Page, enhancement, P2)
Firefox
New Tab Page
Tracking
()
Tracking | Status | |
---|---|---|
firefox66 | --- | fixed |
People
(Reporter: thecount, Assigned: gsuntop)
References
Details
(Keywords: github-merged)
Attachments
(2 files)
e need this to be something we can turn on and off, and can land in nightly 66 without breaking any existing functionality.
It needs designs still, but I can attach wire frames.
Reporter | ||
Comment 1•6 years ago
|
||
Updated•6 years ago
|
Severity: normal → enhancement
Iteration: --- → 66.1 - Dec 10-23
Priority: -- → P2
Updated•6 years ago
|
Iteration: 66.1 - Dec 10-23 → 66.2 - Dec 24 - Jan 6
Reporter | ||
Updated•6 years ago
|
Assignee: nobody → gsuntop
Updated•6 years ago
|
Iteration: 66.2 - Dec 24 - Jan 6 → 66.3 - Jan 7 - 20
Comment 2•6 years ago
|
||
Comment 3•6 years ago
|
||
Commit pushed to master at https://github.com/mozilla/activity-stream
https://github.com/mozilla/activity-stream/commit/51e8180252421503d297bf447d426da146a5f955
Fixes Bug 1514022 – Card Grid component (WIP) (#4661)
Updated•6 years ago
|
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Updated•6 years ago
|
Keywords: github-merged
Comment 4•6 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 6 years ago → 6 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
Comment 5•6 years ago
|
||
Hi,
Can you please provide QA steps.
Thanks,
Brahmini
Flags: needinfo?(sdowne)
Reporter | ||
Comment 6•6 years ago
|
||
Punting this one to Gavin as he implemented it.
Flags: needinfo?(sdowne) → needinfo?(gsuntop)
Assignee | ||
Comment 7•6 years ago
|
||
QA Steps
- set
browser.newtabpage.activity-stream.discoverystream.config
to{"enabled":true,"layout_endpoint":"https://getpocket.com/v3/newtab/layout?version=1&consumer_key=40249-e88c401e1b1f2242d9e441c4&layout_variant=dev-test-all"}
- compare card grid components in new tab to those in the Figma
Flags: needinfo?(gsuntop)
Updated•5 years ago
|
Component: Activity Streams: Newtab → New Tab Page
You need to log in
before you can comment on or make changes to this bug.
Description
•