Closed
Bug 1520568
Opened 6 years ago
Closed 6 years ago
Add 1/3 and 2/3 layouts for CardGrid component
Categories
(Firefox :: New Tab Page, enhancement, P2)
Firefox
New Tab Page
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox66 | --- | fixed |
People
(Reporter: gsuntop, Assigned: gsuntop)
References
Details
(Keywords: github-merged)
Attachments
(1 file)
|
(deleted),
text/x-github-pull-request
|
Details |
No description provided.
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → gsuntop
|
||
Comment 1•6 years ago
|
||
|
||
Comment 2•6 years ago
|
||
Commit pushed to master at https://github.com/mozilla/activity-stream https://github.com/mozilla/activity-stream/commit/3588384e2416861eb8ccf83af9345cc35773d0c2 Bug 1520568 – Add 1/3 and 2/3 layouts for CardGrid (#4667)
|
||
Updated•6 years ago
|
Keywords: github-merged
|
|
||
Comment 3•6 years ago
|
||
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
|
||
Updated•6 years ago
|
Summary: Refine CardGrid component for Activity Stream → Add 1/3 and 2/3 layouts for CardGrid component
|
|
Assignee | |
Comment 6•6 years ago
|
||
QA Steps
- set
browser.newtabpage.activity-stream.discoverystream.configto{"enabled":true,"layout_endpoint":"https://gist.githubusercontent.com/gvn/76af39c92085c247dd5dd7ccc2412618/raw/cc3ea88fe7c95e7b1ba8d4341fd21555004cc434/disco.json"} - compare 1/3 and 2/3 layouts for CardGrid component to those in the Figma
Flags: needinfo?(gsuntop)
|
||
Comment 7•6 years ago
|
||
QA Note :
Widths exceed by some px for the 2/3rd card and also looks intentional..not matching the mock.
-
Like for 2/3rd card grid, requirement is 592px(per mock) but the latest FF Nightly build has 608px.
-
Card borders donot have shadow (grey) per mock but the build has it.
-
Depends on bug 1522726.
Here is the recording : https://www.dropbox.com/home?preview=bug+-+1520568+question.mp4
Flags: needinfo?(gsuntop)
|
|
Assignee | |
Comment 8•6 years ago
|
||
Per discussion with Wolasi: It's ok to leave the build as-is:
ds-column-8: 608px + gridColumnGap: 48px + ds-column-4: 280px = 936px
The mock has different numbers for widths, but that's safe to ignore for now.
Flags: needinfo?(gsuntop)
|
||
Updated•5 years ago
|
Component: Activity Streams: Newtab → New Tab Page
You need to log in
before you can comment on or make changes to this bug.
Description
•