Closed
Bug 1514208
Opened 6 years ago
Closed 6 years ago
[meta] remove dummy binding
Categories
(Thunderbird :: General, enhancement)
Thunderbird
General
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 66.0
People
(Reporter: mkmelin, Assigned: mkmelin)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
jorgk-bmo
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1484976 +++
Remove the dummy binding. As far as we know it's not needed for anything.
|
Assignee | |
Comment 1•6 years ago
|
||
|
|
Assignee | |
Comment 2•6 years ago
|
||
Comment on attachment 9031416 [details] [diff] [review]
bug1514208_dummy.patch
Review of attachment 9031416 [details] [diff] [review]:
-----------------------------------------------------------------
Try seems happy as well. https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=942b5cd1fc45ba39f2c48246e28a3ec1a1530311
Attachment #9031416 -
Flags: review?(acelists)
Comment on attachment 9031416 [details] [diff] [review]
bug1514208_dummy.patch
Review of attachment 9031416 [details] [diff] [review]:
-----------------------------------------------------------------
I don't know enough to decide this.
But we can drop it once the whole file is rewritten into custom elements :)
Attachment #9031416 -
Flags: review?(acelists)
|
|
Assignee | |
Comment 4•6 years ago
|
||
Comment on attachment 9031416 [details] [diff] [review]
bug1514208_dummy.patch
Review of attachment 9031416 [details] [diff] [review]:
-----------------------------------------------------------------
I think the point is to land it now so that in the unlikely scenario it does do anything - we well have time to figure out how to deal with it.
Attachment #9031416 -
Flags: review?(jorgk)
|
||
Comment 5•6 years ago
|
||
Attachment #9031416 -
Flags: review?(jorgk) → review+
|
|
Assignee | |
Updated•6 years ago
|
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/f245d6f5d3b3
remove dummy binding. rs=jorgk
|
|
||
Updated•6 years ago
|
Target Milestone: --- → Thunderbird 66.0
The binding is still referenced:
WARNING: Unable to locate an XBL binding for URI chrome://messenger/content/mailWidgets.xml#dummy in document chrome://messenger/content/FilterEditor.xul: file mozilla/dom/xbl/nsXBLService.cpp, line 766
E.g. at https://searchfox.org/comm-central/source/mail/base/content/messenger.css#77
You need to log in
before you can comment on or make changes to this bug.
Description
•