Closed Bug 1523527 Opened 6 years ago Closed 6 years ago

remove 'dummy' binding's uses in c-c

Categories

(Thunderbird :: General, defect)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 67.0

People

(Reporter: aceman, Assigned: Paenglab)

References

Details

Attachments

(1 file)

The 'dummy' binding removed in bug 1514208 is still referenced:
WARNING: Unable to locate an XBL binding for URI chrome://messenger/content/mailWidgets.xml#dummy in document chrome://messenger/content/FilterEditor.xul: file mozilla/dom/xbl/nsXBLService.cpp, line 766

At https://searchfox.org/comm-central/source/mail/base/content/messenger.css#77

dummy.usesMailWidgets {
-moz-binding: url("chrome://messenger/content/mailWidgets.xml#dummy");
}

This dummy element is in many of our files:

mail/base/content/ABSearchDialog.xul
60 <dummy class="usesMailWidgets"/>
mail/base/content/SearchDialog.xul
80 <dummy class="usesMailWidgets"/>
mail/base/content/messenger.css
76 dummy.usesMailWidgets {
mail/extensions/mailviews/content/mailViewSetup.xul
38 <dummy class="usesMailWidgets"/>
mailnews/base/search/content/FilterEditor.xul
32 <dummy class="usesMailWidgets"/>

It has no effect now as the binding is gone, so we try to remove all these.

Attached patch 1523527-remove-dummy.patch (deleted) — Splinter Review

Like this?

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9039726 - Flags: review?(acelists)
Comment on attachment 9039726 [details] [diff] [review] 1523527-remove-dummy.patch Review of attachment 9039726 [details] [diff] [review]: ----------------------------------------------------------------- Yes, not sure why I didn't notice this! r=mkmelin
Attachment #9039726 - Flags: review?(acelists) → review+

Jörg, can you change the reviewer to r=mkmelin when you land it?

Keywords: checkin-needed

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/534dd6adf201
Bug 1514208 follow-up: Remove dummy elements in C-C. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 67.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: