Closed
Bug 1515083
Opened 6 years ago
Closed 6 years ago
Re-implement telemetry for selected index/type on the new QuantumBar
Categories
(Firefox :: Address Bar, enhancement, P2)
Firefox
Address Bar
Tracking
()
RESOLVED
FIXED
Firefox 67
| Tracking | Status | |
|---|---|---|
| firefox67 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fxsearch])
Attachments
(2 files)
As part of the work for the new QuantumBar, we should ensure that the following telemetry probes continue working:
FX_URLBAR_SELECTED_RESULT_INDEX
FX_URLBAR_SELECTED_RESULT_INDEX_BY_TYPE
FX_URLBAR_SELECTED_RESULT_TYPE
Note: some of this may be able to be consolidated or combined with bug 1500476.
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → standard8
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•6 years ago
|
||
This add checks for everything bar 'preloaded-top-site' which isn't used/enabled at the moment (bug 1527888).
Depends on D19709
|
|
Assignee | |
Comment 2•6 years ago
|
||
This makes the browser_UsageTelemetry_urlbar*.js tests pass for the all of the
FX_URLBAR_SELECTED_RESULT_* histograms apart from the "METHOD" one which will be handled
in bug 1500476.
I have handled the recording of telemetry in the controller, as this seems a better
location than BrowserUsageTelemetry.jsm due to needing to reach into the results and obtain
specific details.
Depends on D19784
|
|
Assignee | |
Comment 3•6 years ago
|
||
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e90244ffbb13
Extend urlbar telemetry tests to cover most reported result types. r=adw
https://hg.mozilla.org/integration/autoland/rev/a8d8de1df9e4
Re-implement telemetry for selected index/type on QuantumBar. r=adw
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/e90244ffbb13
https://hg.mozilla.org/mozilla-central/rev/a8d8de1df9e4
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox67:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
You need to log in
before you can comment on or make changes to this bug.
Description
•