Closed
Bug 1500476
Opened 6 years ago
Closed 6 years ago
Re-implement FX_URLBAR_SELECTED_RESULT_METHOD on the new Quantumbar
Categories
(Firefox :: Address Bar, enhancement, P2)
Firefox
Address Bar
Tracking
()
RESOLVED
FIXED
Firefox 67
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
We have enough in place now that we can implement FX_URLBAR_SELECTED_RESULT_METHOD.
This is basically calls to BrowserUsageTelemetry.recordUrlbarSelectedResultMethod, but we'll need the selection information from the view.
|
Assignee | |
Updated•6 years ago
|
Priority: P3 → P2
|
|
Assignee | |
Updated•6 years ago
|
Blocks: quantumbar-input
|
|
Assignee | |
Updated•6 years ago
|
Summary: Implement FX_URLBAR_SELECTED_RESULT_METHOD on the Quantumbar → Re-implement FX_URLBAR_SELECTED_RESULT_METHOD on the new Quantumbar
|
|
Assignee | |
Updated•6 years ago
|
|
|
Assignee | |
Comment 1•6 years ago
|
||
I discussed with Marco about handling of right-click wrt the current implementation and bug 1366625, and we agreed that right-click would visibly do nothing (currently it "selects" but not really) but would still log telemetry.
Assignee: nobody → standard8
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•6 years ago
|
||
Fixing browser/modules/test/browser/browser_UsageTelemetry_urlbar.js will also be part of this and/or bug 1515083
Blocks: quantumbar-tests
|
|
Assignee | |
Comment 3•6 years ago
|
||
This doesn't enable the rightClick option for telemetry reporting as that is complicated to support, see bug 1528250.
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/57214ac61553
Re-implement FX_URLBAR_SELECTED_RESULT_METHOD on the new Quantumbar. r=dao
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox67:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
|
||
Updated•6 years ago
|
status-firefox65:
--- → wontfix
status-firefox66:
--- → wontfix
You need to log in
before you can comment on or make changes to this bug.
Description
•