Closed Bug 1515714 Opened 6 years ago Closed 6 years ago

Menu bar hover feedback lacks contrast on dark titlebar

Categories

(Firefox :: Theme, defect, P1)

Product:
Firefox
Component:
Theme
Version:
65 Branch
Platform:
Unspecified
Windows 10
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 66
Tracking Flags:
Tracking Status
firefox-esr60 --- unaffected
firefox64 --- unaffected
firefox65 + verified
firefox66 + verified

People

(Reporter: lizzard, Assigned: dao)

References

Details

(Keywords: regression)

Attachments

(2 files)

Screenshot
(deleted), image/png
Details
Bug 1515714 - Fix broken selector. r=mconley
(deleted), text/x-phabricator-request
RyanVM
: approval-mozilla-beta+
Details
Filing a new bug for an issue recently seen by QA from a bug fixed in 2017. +++ I managed to reproduce this issue again with the latest 65.0b5(20181217180946) build. I pulled the following regression : https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=d8e07613f15e55f43d654af8708ffa0cba1710d1&tochange=d341e1dcdfeff2ba187ada77af2e77f4b430604d It seems that the issue which causes this may be Bug 1511905 - Fix window controls' hover and active colors in light titlebars on Windows 10. Johann, how would you like us to proceed with this issue? +++ This bug was initially created as a clone of Bug #1368679 +++ Almost I can not recognize the hover effect. Steps To Reproduce: 1. Enable Menubar 2. Mouse hover over menu or keypress alt key Actual Results: Almost I can not recognize active menu. Expected Results: More lighter background color. PS. I think hover active color of caption buttons are also less contrast
Blocks: 1511905
No longer blocks: 1367384
No longer depends on: 1368679, 1408741
[Tracking Requested - why for this release]:
Iteration: 57.1 - Aug 15 → ---
status-firefox66: ? → affected
tracking-firefox65: --- → ?
Version: 55 Branch → 65 Branch
Priority: P1 → --
Whiteboard: [photon-visual][p3]
Assignee: nobody → dao+bmo
Priority: -- → P1
Summary: Menu bar and window control button hover feedback lacks contrast on dark titlebar → Menu bar hover feedback lacks contrast on dark titlebar

https://hg.mozilla.org/mozilla-central/rev/95d09e99337f

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox66: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
Flags: qe-verify+

Comment on attachment 9033435 [details]
Bug 1515714 - Fix broken selector. r=mconley

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: bug 1511905

User impact if declined: see comment 1

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: No

Needs manual test from QE?: Yes

If yes, steps to reproduce: Switch to the dark theme, show the menu bar and hover over the menu items

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): trivial fix

String changes made/needed:

Attachment #9033435 - Flags: approval-mozilla-beta?

Comment on attachment 9033435 [details]
Bug 1515714 - Fix broken selector. r=mconley

[Triage Comment]
Minor CSS fix-up. Approved for 65.0b10.

Attachment #9033435 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

I have managed to reproduce this issue using Firefox 65.0b9 (BuildId:20190107180200).

This issue is verified fixed using Firefox 66.0a1 (BuildId:20190109214248) and Firefox 65.0b10 (provided in comment 8) on Windows 10 64bit. The hover state for the menu bar elements is successfully visible on default, light and dark themes.

Status: RESOLVED → VERIFIED
status-firefox65: fixed → verified
status-firefox66: fixed → verified
Flags: qe-verify+

Verified as fixed using Firefox 65.0b10(20190109230104) and Firefox 66.0a1(20190109214248) on Windows 10 x64.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: