Closed
Bug 1517306
Opened 6 years ago
Closed 6 years ago
Switch CFR messages pref to remote settings
Categories
(Firefox :: Messaging System, enhancement, P1)
Firefox
Messaging System
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: k88hudson, Assigned: rrosario)
References
Details
Attachments
(2 files)
In Bug 1484726 we created a remote settings bucket for CFR. Let's move our message definitions from the local provider to this remote settings bucket and do a round of QA to ensure everything is working as expected.
|
Reporter | |
Updated•6 years ago
|
|
||
Updated•6 years ago
|
Priority: P1 → P2
|
|
Reporter | |
Updated•6 years ago
|
Iteration: --- → 68.1 - Mar 18 - 31
|
||
Updated•6 years ago
|
Priority: P2 → P1
|
|
Reporter | |
Updated•6 years ago
|
Blocks: cfr-remote-68
|
|
Reporter | |
Updated•6 years ago
|
Blocks: pinned-tabs-68
|
|
Reporter | |
Updated•6 years ago
|
|
|
Reporter | |
Updated•6 years ago
|
No longer blocks: pinned-tabs-68
|
|
||
Updated•6 years ago
|
|
|
||
Updated•6 years ago
|
Iteration: 68.1 - Mar 18 - 31 → 68.2 - Apr 1 - 14
|
|
||
Updated•6 years ago
|
Summary: Switch CFR messages to remote settings → [META] Switch CFR messages to remote settings
|
Assignee | |
Comment 1•6 years ago
|
||
"Un-meta-ing" this bug since we already have meta bug 1535736.
This bug will track flipping the pref to use the remote settings loader for the CFR messages. The pref is "browser.newtabpage.activity-stream.asrouter.providers.cfr" and it lives in browser/app/profile/firefox.js.
Assignee: nobody → rrosario
Keywords: meta
Summary: [META] Switch CFR messages to remote settings → Switch CFR messages pref to remote settings
|
|
Assignee | |
Updated•6 years ago
|
|
|
Assignee | |
Comment 2•6 years ago
|
||
Pushed by rrosario@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5d85f0ed28cc
Switch CFR messages pref to remote settings r=nanj
|
|
Assignee | |
Comment 4•6 years ago
|
||
QA Note:
The main thing to verify is that CFR is still working and nothing regressed. Specifically, the addon and pin tab CFR messages.
In about:newtab#devtools, there should now be a message provider with id="cfr-remote" that has the 4 messages defined (FACEBOOK_CONTAINER_3, GOOGLE_TRANSLATE_3, YOUTUBE_ENHANCE_3 and PIN_TAB).
|
|
Assignee | |
Comment 5•6 years ago
|
||
|
||
Comment 6•6 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox68:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
Pushed by rrosario@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e17500911824
keep the original provider ID for the remote settings provider r=k88hudson
|
||
Comment 8•6 years ago
|
||
| bugherder | ||
|
||
Updated•5 years ago
|
Component: Activity Streams: Newtab → Messaging System
You need to log in
before you can comment on or make changes to this bug.
Description
•