Closed
Bug 1520141
Opened 6 years ago
Closed 6 years ago
Fix referrer policy web platform tests in img-tag
Categories
(Core :: DOM: Security, defect, P2)
Core
DOM: Security
Tracking
()
RESOLVED
FIXED
mozilla66
| Tracking | Status | |
|---|---|---|
| firefox66 | --- | fixed |
People
(Reporter: tnguyen, Assigned: tnguyen)
References
(Blocks 1 open bug)
Details
(Whiteboard: [domsecurity-active])
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
Fix img-tag failures as bug 1514399 comment 9
|
Assignee | |
Updated•6 years ago
|
|
|
Assignee | |
Comment 1•6 years ago
|
||
|
||
Updated•6 years ago
|
Attachment #9036569 -
Attachment description: Bug 1520141 - Correct referrer uri and referrer policy when loading image in iframe We should use parent document's referrer uri and referrer policy in this case → Bug 1520141 - Correct referrer uri and referrer policy when loading image in iframe
|
||
Updated•6 years ago
|
Priority: -- → P2
Whiteboard: [domsecurity-active]
|
|
Assignee | |
Comment 2•6 years ago
|
||
Pushed by tnguyen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3f880d838bb0
Correct referrer uri and referrer policy when loading image in iframe r=baku
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
|
|
Assignee | |
Updated•5 years ago
|
|
||
Comment 6•5 years ago
|
||
The comments on GetDocumentURIAsReferrer that this bug added have weird "???" bits in them. Is this purposeful?
Flags: needinfo?(tnguyen)
|
|
Assignee | |
Comment 7•5 years ago
|
||
Hmm, thanks, it was added for a while ago. The logic should be moved into creating a new referrer info object for a fetch request.
Flags: needinfo?(tnguyen)
|
|
Assignee | |
Comment 9•5 years ago
|
||
Ah sorry, I looked at this too fast and missed your question. I don't see any "???" in the commit, but it was added later in Bug 1513090. I believe it was accidentally added.
Flags: needinfo?(tnguyen)
|
|
||
Comment 10•5 years ago
|
||
Oh, I see. The commit for this bug added non-ASCII quotes in the comments, and then someone else's editor got confused by them and converted them to ???...
|
|
||
Comment 11•5 years ago
|
||
And looks like it got fixed in a followup to bug 1513090, ok.
You need to log in
before you can comment on or make changes to this bug.
Description
•