Closed Bug 1520365 Opened 6 years ago Closed 5 years ago

Lightning add-on major version (x) numbering same as Thunderbird core (x.y.z)

Categories

(Calendar :: Lightning Only, enhancement)

Product:
Calendar
Component:
Lightning Only
Platform:
x86_64
Unspecified
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: ovari123, Assigned: darktrojan)

References

Details

Attachments

(2 files)

ExQuilla for Microsoft Exchange Version History.png
(deleted), image/png
Details
1520365-calendar-version-1.diff
(deleted), patch
Fallen
: review+
Fallen
: approval-calendar-beta+
Details | Diff | Splinter Review

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:64.0) Gecko/20100101 Firefox/64.0

Steps to reproduce:

As Lightning add-on versions are specific to a Thunderbird version, please make the version of the Lightning add-on the same as the version of Thunderbird to which it relates.

This would make it easier to know and find which version of Lightning is required.

If the next Thunderbird ESR to be release is version 60.5.0, please release the next version of the Lightning add-on 60.5. Optionally, the next version of the Lightning add-on could be 60.5.zzzz, where zzzz is the version number of your Lightning add-on.

If the next Thunderbird beta to be released is version 65.0b3, please make the next version of the Lightning add-on 65.0b3. Optionally, the next version of the Lightning add-on for the beta could be 65.0b3.zzz, where zzzz is the version number of your Lightning add-on.

For example, see ExQuilla for Microsoft Exchange Version History [1]. A excerpt is shown in the image attached.

What do you think?

Thank you

[1] https://addons.thunderbird.net/addon/exquilla-exchange-web-services/versions/

What version of Thunderbird are you using on what Linux distribution?

Ubuntu supplies the extension for the current version from the software repository. All the user needs to do is install it using the Synaptic Package Manager or run the command sudo install xul-ext-lightning from the terminal.

Better yet, just download and install a more up to date Thunderbird with Lightning already bundled from https://www.thunderbird.net/en-US/thunderbird/all/

I don't see a need to know and find any version of Lightning because it is already bundled with Thunderbird. The distros also should start bundling it with the distribution.

Component: Untriaged → Lightning Only
Product: Thunderbird → Calendar
Version: 60 → Trunk

Linux Mint 19.1 Cinnamon 64-bit uses Thunderbird 60.2.1

sudo install xul-ext-lightning seesm to not work if you have multiple languages.

Downloading Thunderbird from the website to test a different language updates Lightning as it uses TB60.4.0.

Using the default Thunderbird 60.2.1 in Linux Mint there is no Lightning anymore.

Wouldn't synchronizing versions make sense?

Thank you

My Ubuntu 18.0.4 and Linux Mint 19.1 64-bit supply Thunderbird 60.2.1 without Lightning from the Ubuntu repository. I have the en-US version, used Synaptic to search for Lightning and installed it. I never use it. I prefer the Windows method of installing the latest version, use it (when I'm not using a beta) and keep it updated.

Seems to me it's a bug you should file with Ubuntu to bundle the extension with Thunderbird.

Just like Thunderbird does when you download the application from thunderbird.net.

Maybe you need to review https://support.mozilla.org/en-US/kb/calendar-updates-issues-thunderbird if you are having trouble installing Lightning.

We'll have to wait on the calendar people to respond about whether changing the version number makes sense or not.

Type: defect → enhancement
Hardware: Unspecified → x86_64

to Philipp for action

Flags: needinfo?(philipp)

I'm fine with this, let's use the exact Thunderbird version.

Flags: needinfo?(philipp)

(In reply to Philipp Kewisch [:Fallen] [:📆] from comment #5)

I'm fine with this, let's use the exact Thunderbird version.

Thank you Philipp.

From which version of Thunderbird would the Lightning add-on release have the exact Thunderbird version?

  1. TB alpha/nightly/daily channel release
  2. TB60.7 ESR release
  3. TB68 beta release
  4. TB68.0 ESR release
  5. All of the above
  6. Something else

Thank you once again

We'd land this on nightly and maybe beta. It would not go down to ESR. Which version that corresponds to is determined by the time someone has found time to patch and land this.

Would the Lightning version number be synchronized with the Thunderbird version number for the next Thunderbird ESR after version 68?

The way the trains work, yes. It would be the case for all versions starting with the nightly version we push this on.

Status: UNCONFIRMED → NEW
Ever confirmed: true

Should we do the same to the Google provider extension?

Attached patch 1520365-calendar-version-1.diff (deleted) — — Splinter Review

I think this is the easiest way to implement this change, including bug 1562352. It does leave behind some obsolete code, but I plan to have a serious clean-up of all the build code for calendar add-ons in the near future, especially now bug 1328164 has been finalised.

I doubt even making this change would be effective for existing installs until the next Thunderbird version number change. See bug 1562352 comment 5.

Assignee: nobody → geoff
Status: NEW → ASSIGNED
Attachment #9075083 - Flags: review?(philipp)
Comment on attachment 9075083 [details] [diff] [review]
1520365-calendar-version-1.diff

Review of attachment 9075083 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with this change:

::: calendar/lightning/moz.build
@@ +19,5 @@
>  if CONFIG['MOZ_ARTIFACT_BUILDS']:
>      version_parts = CONFIG['MOZ_APP_VERSION'].split('.')
>      major_version = version_parts[0]
>      DEFINES['THUNDERBIRD_MAXVERSION'] = major_version + '.*'
> +    DEFINES['LIGHTNING_VERSION'] = CONFIG['THUNDERBIRD_VERSION_DISPLAY']

I think LIGHTNING_VERSION needs to be the full Thunderbird version, including the beta number. Otherwise, as you mentioned, there will be no updates.

Also, does your cleanup involve getting rid of LIGHTNING_VERSION and just using THUNDERBIRD_VERSION? I think that would be a change that is fine to make.
Attachment #9075083 - Flags: review?(philipp) → review+

I think LIGHTNING_VERSION needs to be the full Thunderbird version, including the beta number. Otherwise, as you mentioned, there will be no updates.

That is the full version. Confusingly, the one not marked _DISPLAY is what's usually displayed.

Also, does your cleanup involve getting rid of LIGHTNING_VERSION and just using THUNDERBIRD_VERSION? I think that would be a change that is fine to make.

Yeah, but there's several things dependent on LIGHTNING_VERSION and I didn't want to mess with them right now.

I'm not sure if I deliberately didn't ask for beta approval or if I forgot. But this probably should happen there too.

Attachment #9075083 - Flags: approval-calendar-beta?(philipp)

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/20be9dc63498
Use Thunderbird version number, including beta version, for Lightning and GData Provider; r=Fallen

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 7.1
Comment on attachment 9075083 [details] [diff] [review]
1520365-calendar-version-1.diff

Blanket approval where ever this is necessary.
Attachment #9075083 - Flags: approval-calendar-beta?(philipp) → approval-calendar-beta+

Thank you

TB 68 beta 4 / Cal 7.0 (well, just aligned that version with TB):
https://hg.mozilla.org/releases/comm-beta/rev/1877accb8cd4c386d402a6c8da3e32da1574ce94

BTW, this hunk here
https://hg.mozilla.org/comm-central/rev/20be9dc63498#l1.8
doesn't apply to beta, right?

Target Milestone: 7.1 → 7.0

BTW, this hunk here doesn't apply to beta, right?

That's fine. We haven't uplifted that patch and don't really need to.

Regressions: 1580940
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: