For raptor tp6 on windows use mitmproxy executable instead of creating a separate python environment
Categories
(Testing :: Raptor, enhancement, P1)
Tracking
(firefox67 fixed)
Tracking | Status | |
---|---|---|
firefox67 | --- | fixed |
People
(Reporter: Bebe, Assigned: Bebe)
References
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
Mitmproxy provides win executable file now.
https://mitmproxy.org/downloads/#2.0.2/
Update the current setup to use the new executable and remove the python env
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 1•6 years ago
|
||
Assignee | ||
Comment 2•6 years ago
|
||
to run this we need mitmproxy 2.0.2 to be available in tooltool
https://drive.google.com/open?id=10qyWF-bLGVCik3lwjBXpaa1nq7NZDRia
To test this when running the test on win please copy the above file to obj-****/testing/raptor
Assignee | ||
Comment 3•6 years ago
|
||
The mitmproxy file was downloaded from:
https://mitmproxy.org/downloads/#2.0.2/
Assignee | ||
Comment 4•6 years ago
|
||
:rwood can upload the bin to tool tool?
That would help with the review
Comment 5•6 years ago
|
||
(In reply to Florin Strugariu [:Bebe] from comment #4)
:rwood can upload the bin to tool tool?
That would help with the review
Uploaded file (from link in Comment 2) to tooltool; emailed manifest to :bebe.
Updated•6 years ago
|
Updated•6 years ago
|
Assignee | ||
Comment 6•6 years ago
|
||
Looks like we have some issues when running the tests.
I will tests on a windows machine
Assignee | ||
Comment 7•6 years ago
|
||
Try run with windows kill command
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a2580754ccdff010e01ed7fc4b0bb79204c1c6fc
Assignee | ||
Comment 8•6 years ago
|
||
did a little bit of research and mozprocess has a class design to handle processes.[1]
Using this we can kill/start the mitmdump process easily
[1]https://searchfox.org/mozilla-central/source/testing/mozharness/mozprocess/processhandler.py#1062
here is the try job
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c599804cd986e79786705d73e2577c19828af3ff
:rwood can you review this change?
Comment 9•6 years ago
|
||
(In reply to Florin Strugariu [:Bebe] from comment #8)
did a little bit of research and mozprocess has a class design to handle processes.[1]
Using this we can kill/start the mitmdump process easily[1]https://searchfox.org/mozilla-central/source/testing/mozharness/mozprocess/processhandler.py#1062
here is the try job
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c599804cd986e79786705d73e2577c19828af3ff:rwood can you review this change?
I'll have a look at the phabricator review now; please add Raptor tp6 Chromium jobs to your try push ^ thanks!
Comment 10•6 years ago
|
||
I'll have a look at the phabricator review now; please add Raptor tp6 Chromium jobs to your try push ^ thanks!
Also since this is a fairly big change, along with the Chromium tp6 please add to your try push:
-
at least one Firefox benchmark and one Chromium benchmark job i.e. speedometer
-
at least one Raptor tp6 job with --gecko-profile on
-
run the raptor android power test
Thanks!
Assignee | ||
Comment 11•6 years ago
|
||
I ran all the tests just to make sure it works
We have 3 failures but I don't think they are related to this patch
I used the same try run:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c599804cd986e79786705d73e2577c19828af3ff
Comment 12•6 years ago
|
||
Comment 13•6 years ago
|
||
Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=busted&revision=a5ad662d5bbb4f2f2a8964782e9cdab91385b8ca&searchStr=android&selectedJob=228185007
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=228185007&repo=autoland&lineNumber=34989
Backout link: https://hg.mozilla.org/integration/autoland/rev/23a24796db2bb56ec2172f747fcd1c6dbc23c358
Comment 14•6 years ago
|
||
This looks to have triggered the nightlies to run on autoland: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=usercancel%2Csuccess%2Cpending%2Crunning%2Ctestfailed%2Cbusted%2Cexception&searchStr=nightly&revision=a5ad662d5bbb4f2f2a8964782e9cdab91385b8ca
Florin, please take a look. Thank you.
Comment 15•6 years ago
|
||
I think the nightly builds were added as a result of an add-new job:
https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=usercancel%2Csuccess%2Cpending%2Crunning%2Ctestfailed%2Cbusted%2Cexception&searchStr=decision&revision=a5ad662d5bbb4f2f2a8964782e9cdab91385b8ca&selectedJob=228184946
Assignee | ||
Comment 16•6 years ago
|
||
Yes I triggered by mistake those jobs.
I was trying to run all raptor jobs to make sure this change works as expected
Comment 17•6 years ago
|
||
Comment 18•6 years ago
|
||
bugherder |
Description
•