The current search handoff implementation switches focus to the awesomebar when the user mouse clicks on the in-content search bar (but the styles are faked so the user doesn't notice). This turned out to be unnecessary. In the case of keyboard navigation, the focus isn't switched until the user types a printable character. This is working fine so we should switch the mouse navigation case to do the same.

There is already an approved pull request for the change. Just waiting for :k88hudson to give the final nod.

If we make this change, we can undo the changes from bug 1514352 and wontfix bug 1515044.

Notes for QA:

Please verify the following cases are working properly:

• tab to the in-content search and start typing
• tab to the in-content search and paste some content
• tab to the in-content search and hit <Enter> (should shift focus to awesome bar)
• mouse click on the in-content search and start typing
• right-click on the in-content search and paste some content via context menu

Also, it would be great if this could be tested on a slower machine to make sure there are no issues with lag.

https://hg.mozilla.org/mozilla-central/rev/25af8129d9f2

I have verified that the issue is no longer reproducible on the latest Nightly 66.0a1 (Build ID 20190120213632) on Windows 10 x64, Mac OS 10.13.3, and Arch Linux 4.14. I've verified all of the scenarios from comment 4.

I have observed a bit of lag when you make a 2nd search that generates suggestions, where the suggestions from the 1st search will briefly appear before the new ones take their place. But this is also reproducible with the awesome bar alone.