Closed Bug 1521446 Opened 6 years ago Closed 6 years ago

search box in Firefox Home page doesn't work if "search when typing" option is on

Categories

(Firefox :: New Tab Page, defect, P1)

Product:
Firefox
Component:
New Tab Page
Version:
66 Branch
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 66
Iteration:
66.4 - Jan 21 - 27
Tracking Flags:
Tracking Status
firefox-esr60 --- unaffected
firefox64 --- unaffected
firefox65 --- unaffected
firefox66 + verified

People

(Reporter: dekeltal, Assigned: rrosario)

References

Details

(Keywords: regression)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:66.0) Gecko/20100101 Firefox/66.0

Steps to reproduce:

  • Switch ON the option: Options > General > Browsing > Search for text when you start typing
  • Open Firefox Home page (by opening a new tab, or going to about:home)
  • Click in the "Search the web" box
  • Start typing

Actual results:

The text appears in the search panel at the bottom (search in page)

Expected results:

Text should appear in the address bar, to allow searching the web.

Blocks: 1508388
status-firefox64: --- → unaffected
status-firefox65: --- → unaffected
status-firefox66: --- → affected
status-firefox-esr60: --- → unaffected
Component: Untriaged → Activity Streams: Newtab
Status: UNCONFIRMED → NEW
Ever confirmed: true
tracking-firefox66: --- → ?
Keywords: regression

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=cc2853aad2c4180fdfc0504afd84f94d2ef1371f&tochange=25af8129d9f2c71b724398b64407cbde3215f407

Regressed by: 25af8129d9f2 Ed Lee — Bug 1520691 - Add Discovery components, search polish and bug fixes to Activity Stream r=k88hudson

Blocks: 1520691

i presume this is due to the changes from bug 1520449 in particular. ricky, could you look into this?

Blocks: 1520449
Flags: needinfo?(rrosario)
Assignee: nobody → rrosario
Iteration: --- → 66.3 - Jan 7 - 20
Flags: needinfo?(rrosario)
Priority: -- → P1
Depends on: 1521757
Iteration: 66.3 - Jan 7 - 20 → 66.4 - Jan 21 - 27

This is fixed in latest nightly.

The fix was part of this commit (bug 1521757 which was included in bug 1522379):
https://hg.mozilla.org/mozilla-central/rev/9fb96d1b0b37

Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
status-firefox66: affected → fixed
Target Milestone: --- → Firefox 66
Flags: qe-verify+
Component: Activity Streams: Newtab → New Tab Page

I have reproduced the issue on the affected Nightly build 66.0a1(2019-1-20) on Windows 10 x64, Macos 10.14.6 and Linux 18.04.2.
Verified - fixed on Firefox 66.0a1 (2019-1-24) on Windows 10 x64, Macos 10.14.6 and Linux 18.04.2.
When typing in the "Search the web" box the results will appear in the address bar.

Status: RESOLVED → VERIFIED
status-firefox66: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.