Closed Bug 1520512 Opened 6 years ago Closed 6 years ago

When type something in-content search using Japanese IME, caret is staying in in-content search field

Categories

(Firefox :: New Tab Page, defect, P1)

66 Branch
x86_64
Windows 10
defect

Tracking

()

RESOLVED FIXED
Firefox 66
Iteration:
66.4 - Jan 21 - 27
Tracking Status
firefox-esr60 --- unaffected
firefox64 --- unaffected
firefox65 --- unaffected
firefox66 + fixed

People

(Reporter: alice0775, Assigned: rrosario)

References

Details

(4 keywords)

[Tracking Requested - why for this release]: Completely broken caret positioning if use Japanese IME

Reproduced with MS-IME and/or ATOK2016 as well.

Reproducible : always

Steps To Reproduce:

  1. Open New Tab
  2. Click on in-content search
  3. Type something in-content search using Japanese IME
    --- now, character displays in address bar as expected
    --- However, no caret display at insertion point of typed text --- BUG!
    --- Instead, the caret is blinking in in-content search field --- BUG!
    --- And also in-content search field does not disappear --- BUG!
  4. Commit conversion strings
    --- Caret is still blinking in in-content search field --- BUG!

Actual Results:
as above

Expected Results:
3. Type something in-content search using Japanese IME
--- now, character displays in address bar
--- Caret should be blinking at end of text in address bar
--- in-content search field should disappear
4. Commit conversion strings
--- Caret is blinking at end of text in address bar

Component: Address Bar → Activity Streams: Newtab

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=2809c756574d28c25d031eecd41779d3392c44d4&tochange=226b130b6360f05f7329b3a836177af5bb32fd1d

Regressed by: 226b130b6360 Ed Lee — Bug 1519303 - Add hand-off triggers, add-on icons and bug fixes to Activity Stream r=k88hudson

Ed Lee,
Your patch seems to cause the regression. Can you please look into this?

Blocks: 1519303
Flags: needinfo?(edilee)

I'll take a look. Thanks

Assignee: nobody → rrosario
Iteration: --- → 66.3 - Jan 7 - 20
Flags: needinfo?(edilee)
Priority: -- → P1
Depends on: 1521757
Iteration: 66.3 - Jan 7 - 20 → 66.4 - Jan 21 - 27

This looks fixed in latest nightly. I tested using the Japanese IME on Mac and Windows 10.

The fix was part of this commit (bug 1521757 which was included in bug 1522379):
https://hg.mozilla.org/mozilla-central/rev/9fb96d1b0b37

Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.