Closed
Bug 1521757
Opened 6 years ago
Closed 6 years ago
Port PBM search hand-off implementation changes to Activity Stream
Categories
(Firefox :: New Tab Page, enhancement, P1)
Firefox
New Tab Page
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox66 | --- | fixed |
People
(Reporter: rrosario, Assigned: rrosario)
References
Details
(Keywords: github-merged)
Attachments
(1 file)
|
(deleted),
text/x-github-pull-request
|
Details |
The new search hand-off in private browsing just landed (bug 1508364). It is behaves slightly different and fixes some bugs.
- prepend the @searchalias (@google, for example) on hand-off
- back to using the "hidden focus" trick where we style so that the in-content search appears focused but the url bar is really focused
- better handles input from IMEs (Japanese IME, for example)
|
||
Comment 1•6 years ago
|
||
|
Assignee | |
Updated•6 years ago
|
Summary: Backport search hand-off implementation changes from new private browsing ui with search → Port PBM search hand-off implementation changes to Activity Stream
|
||
Comment 2•6 years ago
|
||
Commit pushed to master at https://github.com/mozilla/activity-stream
https://github.com/mozilla/activity-stream/commit/531691b02de4132215173bb5317e4d4ae56078fe
Bug 1521757 - Port PBM search hand-off implementation changes to Activity Stream (#4697)
|
|
Assignee | |
Updated•6 years ago
|
Keywords: github-merged
|
||
Comment 3•6 years ago
|
||
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
|
||
Updated•5 years ago
|
Component: Activity Streams: Newtab → New Tab Page
|
|
||
Updated•4 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•