<table rules=rows style=border:double> shows solid border
Categories
(Core :: Layout: Tables, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr60 | --- | unaffected |
firefox64 | --- | wontfix |
firefox65 | --- | fixed |
firefox66 | --- | fixed |
People
(Reporter: moz, Assigned: emilio)
References
()
Details
(Keywords: regression)
Attachments
(2 files)
(deleted),
text/html
|
Details | |
(deleted),
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details |
See http://elektronotdienst-nuernberg.de/Stoerung/Fuerth-Zdf-Stein-Wdst-Feucht-SC-RH/
There is a table with a solid black border around.
That should be a double border and was for ages until recently.
I think this bug is new in Fx 64, also in Nightly 66
Markup is like this:
<style> table { border:double } </style>
<table rules=rows>
Works in Fx 63 (I think), Chrome, IE, etc.
Assignee | ||
Comment 2•6 years ago
|
||
Looks like I broke this, sorry! Thanks a lot for the report, feels weird that nobody noticed until now... Will take a look.
Assignee | ||
Comment 3•6 years ago
|
||
Gotta love C++... I missed the break;
for that branch so we were always
falling back to the solid border rendering path (which we use if the border is
too small).
Assignee | ||
Comment 4•6 years ago
|
||
Comment on attachment 9037565 [details]
Bug 1521066 - Fix double border rendering of border-collapsed tables. r=jrmuizel
[Beta/Release Uplift Approval Request]
Feature/Bug causing the regression: Bug 1487407
User impact if declined: Some tables may render solid borders instead of double.
Is this code covered by automated tests?: Yes
Has the fix been verified in Nightly?: No
Needs manual test from QE?: No
If yes, steps to reproduce:
List of other uplifts needed: None
Risk to taking this patch: Low
Why is the change risky/not risky? (and alternatives if risky): Just adds back a break;
statement which prevents us to fall back to the solid border path we use when the border is too small.
String changes made/needed:
Comment 6•6 years ago
|
||
bugherder |
Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:66.0) Gecko/20100101 Firefox/66.0
Confirming that testcase and URL are fixed with today's Nightly.
Thanks!
Updated•6 years ago
|
Comment 10•6 years ago
|
||
Comment on attachment 9037565 [details]
Bug 1521066 - Fix double border rendering of border-collapsed tables. r=jrmuizel
[Triage Comment]
Extremely simple fix with tests for a table border rendering regression. Approved for 65.0rc1.
Comment 11•6 years ago
|
||
bugherder uplift |
Description
•