Closed Bug 1523158 Opened 6 years ago Closed 6 years ago

try to make test_bug574663.html a tad more stable

Categories

(Core :: DOM: UI Events & Focus Handling, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: smaug, Assigned: smaug)

References

Details

Attachments

(1 file)

Attached patch momentum_scroll.diff (deleted) — Splinter Review

test_bug574663.html starts to fail more often when one tweaks RefreshDriver ticking during page load, especially like in bug 936025.
The test has failed also other ways (bug 1459135, bug 1439484).

the patch tries to stabilize the test a bit. At least locally seems to work, but then, it is win7 opt which fails most often and I don't have access to such system.

Attachment #9039392 - Flags: review?(kats)
Comment on attachment 9039392 [details] [diff] [review] momentum_scroll.diff Review of attachment 9039392 [details] [diff] [review]: ----------------------------------------------------------------- Not really clear to me how this helps but sure, it doesn't look like it would make anything worse.
Attachment #9039392 - Flags: review?(kats) → review+
Pushed by opettay@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/754f9877d4ba try to make test_bug574663.html a tad more stable, r=kats
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Depends on: 1524189
Depends on: 1524207
Component: Event Handling → User events and focus handling
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: