Closed Bug 1523600 Opened 6 years ago Closed 6 years ago

[de-xbl] Remove calendar-invitations-richlistbox binding.

Categories

(Calendar :: Lightning Only, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: arshad, Assigned: arshad)

References

Details

Attachments

(1 file, 6 obsolete files)

No description provided.
Assignee: nobody → arshdkhn1
Blocks: 1517040
Attached patch calendar-invitations-richlistbox.patch (obsolete) (deleted) — Splinter Review
Attachment #9041713 - Flags: review?(mkmelin+mozilla)
Attached patch calendar-invitations-richlistbox.patch (obsolete) (deleted) — Splinter Review
Attachment #9041713 - Attachment is obsolete: true
Attachment #9041713 - Flags: review?(mkmelin+mozilla)
Attachment #9041714 - Flags: review?(mkmelin+mozilla)
Comment on attachment 9041714 [details] [diff] [review] calendar-invitations-richlistbox.patch Review of attachment 9041714 [details] [diff] [review]: ----------------------------------------------------------------- For this too, please add doc on how to even find it.
Attachment #9041714 - Flags: review?(mkmelin+mozilla)

hmm, I thought you'd know this. All I know right now is to open the dialog by calling the openInvitationsDialog method or clicking on hidden hbox(https://searchfox.org/comm-central/source/calendar/lightning/content/messenger-overlay-sidebar.xul#301). I have asked on irc so probably someone can tell use how to open this dialog. I tried sendding a calendar-invite but it didnt' work for me.

Ah yes I recall now where it's seen. There's this indicator in the status bar where unanswered invitations show up under certain circumstances. Clicking this indicator pops up a dialog.

While our widgets are reusable in theory, I think it would be really useful that we document the typical usage now as we go. It's also easier to review and easier for someone to track down possible regressions if they can see in the bugs what part of the UI was converted.

And it goes without saying, you really need to check your conversion in real life. Dry coding isn't enough.

This is for dealing with serverside managed caldav invitations. This is not related to email scheduling. You need to be subscribed to a caldav server that supports caldav scheduling to get the status bar link displayed (and have been invited to have invitations in the dialog).

Hey I have subscribed to my gmail calendar. What exactly do I need to do to see the invitation?

Flags: needinfo?(makemyday)

Assuming the calendar is set up to be accessed through caldav, it needs to have received an invitation, to which you didn't already respond anything.

I am not sure what you mean.

All I know is I have my own google calendar set up in lightning, accessing it through caldav (not using the gdata provider). I also have my wife's calendar set up the same way. Whey she has unanswered invitations (e.g. from me), there's a link in the status bar about invitations. Clicking it opens a dialog and I believe this is the dialog in question.

(In reply to Magnus Melin [:mkmelin] from comment #11)

All I know is I have my own google calendar set up in lightning, accessing it through caldav (not using the gdata provider). I also have my wife's calendar set up the same way. Whey she has unanswered invitations (e.g. from me), there's a link in the status bar about invitations. Clicking it opens a dialog and I believe this is the dialog in question.

do you mean unansweredd event invitations?

Yes. Are there any other kind?

(In reply to Magnus Melin [:mkmelin] from comment #13)

Yes. Are there any other kind?

Not sure.

Attached image Screenshot 2019-02-18 at 2.13.03 AM.png (obsolete) (deleted) —

I tried sending the event invite from one caldav subscribed cal to the another.. Not sure whether this what you meant but I dont see that invite link in statusbar.

Attached patch calendar-invitations-richlistbox.patch (obsolete) (deleted) — Splinter Review

Tested out the patch and it appears to be working. For making the invitation link visible, I sent event invite to an an email which is logged in on my Thunderbird and I created a local and caldav calendar using that email.

Attachment #9041714 - Attachment is obsolete: true
Attachment #9044516 - Attachment is obsolete: true
Flags: needinfo?(makemyday)
Attachment #9044699 - Flags: feedback?(mkmelin+mozilla)
Attached patch calendar-invitations-richlistbox.patch (obsolete) (deleted) — Splinter Review
Attachment #9044699 - Attachment is obsolete: true
Attachment #9044699 - Flags: feedback?(mkmelin+mozilla)
Attachment #9045610 - Flags: review?(philipp)
Attachment #9045610 - Flags: feedback?(mkmelin+mozilla)
Comment on attachment 9045610 [details] [diff] [review] calendar-invitations-richlistbox.patch Review of attachment 9045610 [details] [diff] [review]: ----------------------------------------------------------------- Given that this is such a super small thing, only used once, I think it makes sense to just inline it You can just as well put something like the below here https://searchfox.org/comm-central/source/calendar/base/content/dialogs/calendar-invitations-dialog.js#37 let newNode = document.createXULElement("richlistitem"); newNode.calendarItem = item; richListBox.appendChild(newNode); ::: calendar/base/content/dialogs/calendar-invitations-dialog.js @@ +4,5 @@ > > /* exported onLoad, onUnload, onAccept, onCancel */ > > var { cal } = ChromeUtils.import("resource://calendar/modules/calUtils.jsm"); > @extends {MozElements.RichListBox} ... and other documentation
Attachment #9045610 - Flags: review?(philipp)
Attachment #9045610 - Flags: feedback?(mkmelin+mozilla)
Attached patch calendar-invitations-richlistbox.patch (obsolete) (deleted) — Splinter Review
Attachment #9045610 - Attachment is obsolete: true
Attachment #9045904 - Flags: review?(philipp)
Attachment #9045904 - Flags: feedback?(mkmelin+mozilla)
Comment on attachment 9045904 [details] [diff] [review] calendar-invitations-richlistbox.patch Review of attachment 9045904 [details] [diff] [review]: ----------------------------------------------------------------- Looks correct.
Attachment #9045904 - Flags: feedback?(mkmelin+mozilla) → feedback+
Attachment #9045904 - Flags: review?(philipp) → review+
Attachment #9045904 - Attachment is obsolete: true
Attachment #9047755 - Flags: review+
Keywords: checkin-needed

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/44efa8f82796
Migrate calendar-invitations-richlistbox binding to custom element. r=philipp

Status: NEW → RESOLVED
Closed: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 6.9
Depends on: 1538533
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: